Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ksmemory_notifyUnhandledFatalSignal memory crash #594

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix ksmemory_notifyUnhandledFatalSignal memory crash #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/KSCrashRecording/Monitors/KSCrashMonitor_Memory.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,4 +570,9 @@ bool ksmemory_previous_session_was_terminated_due_to_memory(bool *userPerceptibl

bool ksmemory_get_fatal_reports_enabled(void) { return g_FatalReportsEnabled; }

void ksmemory_notifyUnhandledFatalSignal(void) { g_memory->fatal = true; }
void ksmemory_notifyUnhandledFatalSignal(void)
{
if (g_memory) {
g_memory->fatal = true;
}
}
5 changes: 5 additions & 0 deletions Tests/KSCrashRecordingTests/KSCrashMonitor_Memory_Tests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,4 +313,9 @@ - (void)testNonFatalReportLevel
XCTAssertEqual(ksmemory_get_nonfatal_report_level(), KSCrashAppMemoryStateUrgent);
}

- (void)testNotifyUnhandledFatalSignal
{
XCTAssertNoThrow(ksmemory_notifyUnhandledFatalSignal(), @"NULL safety for g_memory");
}

@end
Loading