Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add code generation to Makefile #27

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Sep 28, 2023

  • Pre-install grpc-gateway plugin in developer Docker image
  • Add generate make target to run protoc and automatically download required .proto files
  • Add developer instructions to README.md

* Pre-install grpc-gateway plugin in developer Docker image
* Add `generate` make target to run protoc and automatically
  download required .proto files
* Add developer instructions to README.md

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from rafvasq September 28, 2023 01:21
@ckadner
Copy link
Member Author

ckadner commented Sep 28, 2023

@rafvasq -- when you get a chance, could you try the revised developer setup and instructions?

make generate or make run generate should work on a fresh clone and/or after deleting your previously downloaded google/api/*.proto files.

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckadner. The developer setup/instructions look good aside from the small typo below and both make generate and make run generate on a fresh clone worked for me.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Christian Kadner <[email protected]>
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner ckadner merged commit 68c135f into kserve:main Sep 28, 2023
3 checks passed
@ckadner ckadner added this to the v0.11.1 milestone Oct 2, 2023
@ckadner ckadner self-assigned this Oct 2, 2023
@ckadner ckadner added the documentation Improvements or additions to documentation label Oct 2, 2023
@ckadner
Copy link
Member Author

ckadner commented Nov 28, 2023

/reopen

Copy link

oss-prow-bot bot commented Nov 28, 2023

@ckadner: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ckadner
Copy link
Member Author

ckadner commented Nov 28, 2023

/lgtm

spolti referenced this pull request in spolti/rest-proxy Jan 10, 2024
* Pre-install grpc-gateway plugin in developer Docker image
* Add `generate` make target to run protoc and download required .proto files
* Add developer instructions to README.md

---------

Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Spolti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants