-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add code generation to Makefile #27
Conversation
* Pre-install grpc-gateway plugin in developer Docker image * Add `generate` make target to run protoc and automatically download required .proto files * Add developer instructions to README.md Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
@rafvasq -- when you get a chance, could you try the revised developer setup and instructions?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ckadner. The developer setup/instructions look good aside from the small typo below and both make generate
and make run generate
on a fresh clone worked for me.
Signed-off-by: Christian Kadner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/reopen |
@ckadner: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
* Pre-install grpc-gateway plugin in developer Docker image * Add `generate` make target to run protoc and download required .proto files * Add developer instructions to README.md --------- Signed-off-by: Christian Kadner <[email protected]> Signed-off-by: Spolti <[email protected]>
generate
make target to run protoc and automatically download required .proto files