-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ModelMetadata endpoint #26
Conversation
Signed-off-by: Rafael Vasquez <[email protected]>
simply tested this and I confirm that this work well
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafvasq -- need a few updates for the go.mod dependencies. I get different generated results, without these updates
Signed-off-by: Rafael Vasquez <[email protected]>
Thanks @rafvasq -- did you also regenerate the protos? With Note: "Your version" is my version using UPDATE: I did not notice this earlier, but I actually had different versions of
Although // Dial creates a client connection to the given target.
func Dial(target string, opts ...DialOption) (*ClientConn, error) {
return DialContext(context.Background(), target, opts...)
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Motivation
KServe V2 API's ModelMetadata endpoint is not yet supported in the
rest-proxy
grpc-gateway.Modifications
Extend grpc-gateway to include it in addition to the
Infer
call already implemented.Result
Resolves #14 and kserve/modelmesh-serving#418