Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip ClusterServingRuntime deletion if deployed using --namespace-scope-mode #421

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Aug 22, 2023

Motivation

delete.sh script attempts to delete ClusterServingRuntime resources when they don't exist after deploying with --namespace-scope-mode, interrupting the script and leaving multiple resources behind.

Modifications

Set and use NAMESPACE_SCOPE env variable to check whether to skip ClusterServingRuntime deletion.

Result

Resolves #420

@rafvasq rafvasq requested a review from ckadner August 22, 2023 19:53
@rafvasq rafvasq changed the title Add and use namespace face fix: Skip ClusterServingRuntime deletion if deployed using --namespace-scope-mode Aug 22, 2023
@rafvasq rafvasq force-pushed the namespace-scope-delete-fix branch from 4e4238c to 8f46ada Compare August 22, 2023 19:58
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq removed the request for review from joerunde August 22, 2023 20:18
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq marked this pull request as ready for review August 24, 2023 15:41
@rafvasq rafvasq requested a review from Jooho August 24, 2023 15:42
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafvasq -- I think the way we define and test for the is_namespace_scoped variable needs to be hardened a bit

scripts/delete.sh Outdated Show resolved Hide resolved
scripts/delete.sh Outdated Show resolved Hide resolved
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested a review from ckadner September 7, 2023 13:57
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  echo false

🙃

scripts/delete.sh Outdated Show resolved Hide resolved
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested a review from ckadner September 8, 2023 15:12
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, rafvasq
To complete the pull request process, please assign njhill after the PR has been reviewed.
You can assign the PR to them by writing /assign @njhill in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 5dfc278 into kserve:main Sep 8, 2023
5 checks passed
@ckadner
Copy link
Member

ckadner commented Sep 8, 2023

Thanks @rafvasq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete.sh script resource mapping not found error
3 participants