-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip ClusterServingRuntime
deletion if deployed using --namespace-scope-mode
#421
Conversation
ClusterServingRuntime
deletion if deployed using --namespace-scope-mode
Signed-off-by: Rafael Vasquez <[email protected]>
4e4238c
to
8f46ada
Compare
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rafvasq -- I think the way we define and test for the is_namespace_scoped
variable needs to be hardened a bit
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo false
🙃
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @rafvasq |
Motivation
delete.sh
script attempts to deleteClusterServingRuntime
resources when they don't exist after deploying with--namespace-scope-mode
, interrupting the script and leaving multiple resources behind.Modifications
Set and use
NAMESPACE_SCOPE
env variable to check whether to skipClusterServingRuntime
deletion.Result
Resolves #420