chore: Reuse existing developer image

[ckadner]

Motivation

Each time running lint using the developer image, i.e. make run fmt, the build.develop Make target is executed, calling scripts/build_docker.sh which (re)builds the developer image each time, which despite using cached image layers takes extra time and clutters the terminal with Docker build output that is not relevant with respect to the actual make goal having been invoked.

[modelmesh-runtime-adapter] (main=)$ make run fmt

Makefile:74: warning: overriding commands for target `fmt'
Makefile:60: warning: ignoring old commands for target `fmt'
./scripts/build_docker.sh --target develop
[+] Building 1.1s (15/15) FINISHED                                                                                                                            docker:colima
 => [internal] load build definition from Dockerfile                                                                                                                   0.0s
 => => transferring dockerfile: 7.60kB                                                                                                                                 0.0s
 => [internal] load .dockerignore                                                                                                                                      0.0s
 => => transferring context: 93B                                                                                                                                       0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi8/go-toolset:1.17                                                                                       1.0s
 => [develop  1/10] FROM registry.access.redhat.com/ubi8/go-toolset:1.17@sha256:db868166dd2ea38bdb8507e0cb1c9a295622fb6d8bdd70718af1405679ca0a19                       0.0s
 => [internal] load build context                                                                                                                                      0.0s
 => => transferring context: 98B                                                                                                                                       0.0s
 => CACHED [develop  2/10] RUN --mount=type=cache,target=/root/.cache/dnf:rw     dnf install --setopt=cachedir=/root/.cache/dnf -y --nodocs         python3         p  0.0s
 => CACHED [develop  3/10] RUN --mount=type=cache,target=/root/.cache/pip     pip3 install pre-commit                                                                  0.0s
 => CACHED [develop  4/10] RUN set -eux;     amd64=x86_64;     arm64=aarch_64;     ppc64le=ppcle_64;     s390x=s390_64;     wget -qO protoc.zip "https://github.com/p  0.0s
 => CACHED [develop  5/10] WORKDIR /opt/app                                                                                                                            0.0s
 => CACHED [develop  6/10] COPY go.mod go.sum ./                                                                                                                       0.0s
 => CACHED [develop  7/10] RUN true     && go get google.golang.org/grpc/cmd/protoc-gen-go-grpc     && go install google.golang.org/protobuf/cmd/protoc-gen-go         0.0s
 => CACHED [develop  8/10] COPY .pre-commit-config.yaml ./                                                                                                             0.0s
 => CACHED [develop  9/10] RUN git init &&     pre-commit install-hooks &&     rm -rf .git                                                                             0.0s
 => CACHED [develop 10/10] RUN go mod download                                                                                                                         0.0s
 => exporting to image                                                                                                                                                 0.0s
 => => exporting layers                                                                                                                                                0.0s
 => => writing image sha256:feb1d14c1a753a7e4494b9b53f8132fec927c39e565eacede9ea2a460a78ebec                                                                           0.0s
 => => naming to docker.io/kserve/modelmesh-runtime-adapter-develop:reuse_existing_dev_image-20231027T220733PDT                                                        0.0s
 => => naming to docker.io/kserve/modelmesh-runtime-adapter-develop:latest                                                                                             0.0s
./scripts/develop.sh make fmt
./scripts/fmt.sh
golangci-lint............................................................Passed
prettier.................................................................Passed

Modifications

• Add flag --use-existing to scripts/build_docker.sh to skip the Docker build it the image exists
• Add internal Make target use.develop which call scripts/build_docker.sh with the new flag --use-existing
• Add env vars DOCKER_USER and IMAGE_TAG to scripts/develop.sh to be consistent with scripts/build_docker.sh

Result

[modelmesh-runtime-adapter_ckadner] (reuse_existing_dev_image=)$ make run fmt

Makefile:74: warning: overriding commands for target `fmt'
Makefile:60: warning: ignoring old commands for target `fmt'
./scripts/build_docker.sh --target develop --use-existing
./scripts/develop.sh make fmt
./scripts/fmt.sh
golangci-lint............................................................Passed
prettier.................................................................Passed

[rafvasq]

Thanks Christian!

/lgtm

[kserve-oss-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ckadner,rafvasq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kserve-oss-bot]

New changes are detected. LGTM label has been removed.