Skip to content

Commit

Permalink
chore: Ensure consistent version of generate proto stubs (#58)
Browse files Browse the repository at this point in the history
Ensure the versions of the generated protobuf code stubs are consistent
with the versions as specified in the Dockerfile and the go.mo file.

- protoc             v3.21.5
- protoc-gen-go      v1.28.1
- protoc-gen-go-grpc v1.3.0

Signed-off-by: Christian Kadner <[email protected]>
  • Loading branch information
ckadner authored Oct 12, 2023
1 parent ad03d9a commit 41be615
Show file tree
Hide file tree
Showing 16 changed files with 294 additions and 136 deletions.
8 changes: 6 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,13 @@ WORKDIR /opt/app
COPY go.mod go.sum ./

# Install go protoc plugins
# no required module provides package google.golang.org/grpc/cmd/protoc-gen-go-grpc
# to add it run `go get google.golang.org/grpc/cmd/protoc-gen-go-grpc`
ENV PATH $HOME/go/bin:$PATH
RUN go get google.golang.org/protobuf/cmd/protoc-gen-go \
google.golang.org/grpc/cmd/protoc-gen-go-grpc \
RUN true \
&& go get google.golang.org/grpc/cmd/protoc-gen-go-grpc \
&& go install google.golang.org/protobuf/cmd/protoc-gen-go \
google.golang.org/grpc/cmd/protoc-gen-go-grpc \
&& protoc-gen-go --version \
&& true

Expand Down
4 changes: 2 additions & 2 deletions internal/proto/kfserving-predict-v2/inference.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 23 additions & 14 deletions internal/proto/kfserving-predict-v2/inference_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 17 additions & 3 deletions internal/proto/mlserver/dataplane/dataplane.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 41be615

Please sign in to comment.