Update tests, change trim checks and exception text

ksdev-pl · Jan 15, 2018 · f47aaa0 · f47aaa0
1 parent 86f3d14
commit f47aaa0
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -15,14 +15,14 @@ Via Maven
 <dependency>
   <groupId>pl.ksdev</groupId>
   <artifactId>slugify</artifactId>
-  <version>0.2</version>
+  <version>0.3</version>
 </dependency>
 ```
 
 Via Gradle
 
 ```groovy
-compile 'pl.ksdev:slugify:0.2'
+compile 'pl.ksdev:slugify:0.3'
 ```
 
 ## Usage
@@ -45,5 +45,5 @@ The MIT License (MIT). Please see [License File](LICENSE) for more information.
 [ico-coveralls]: https://img.shields.io/coveralls/github/ksdev-pl/slugify.svg?style=flat-square
 
 [link-travis]: https://travis-ci.org/ksdev-pl/slugify
-[link-maven]: http://search.maven.org/#artifactdetails%7Cpl.ksdev%7Cslugify%7C0.2%7Cjar
+[link-maven]: http://search.maven.org/#artifactdetails%7Cpl.ksdev%7Cslugify%7C0.3%7Cjar
 [link-coveralls]: https://coveralls.io/github/ksdev-pl/slugify?branch=master
diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>pl.ksdev</groupId>
     <artifactId>slugify</artifactId>
-    <version>0.2</version>
+    <version>0.3</version>
     <packaging>jar</packaging>
 
     <name>Slugify</name>

diff --git a/src/main/java/pl/ksdev/slugify/SimpleSlugService.java b/src/main/java/pl/ksdev/slugify/SimpleSlugService.java
@@ -217,9 +217,7 @@ public SimpleSlugService() {
      */
     public SimpleSlugService(int maxSlugLength) {
         if (maxSlugLength <= 0) {
-            throw new IllegalArgumentException(
-                "maxSlugLength must be greater than zero"
-            );
+            throw new IllegalArgumentException("maxSlugLength must be > 0");
         }
 
         this.maxSlugLength = maxSlugLength;
@@ -253,13 +251,11 @@ public String slugify(String text) {
         }
 
         // Trim dashes
-        if (slug.length() > 0) {
-            if (slug.charAt(0) == '-') {
-                slug.deleteCharAt(0);
-            }
-            if (slug.charAt(slug.length() - 1) == '-') {
-                slug.deleteCharAt(slug.length() - 1);
-            }
+        if (slug.length() > 0 && slug.charAt(0) == '-') {
+            slug.deleteCharAt(0);
+        }
+        if (slug.length() > 0 && slug.charAt(slug.length() - 1) == '-') {
+            slug.deleteCharAt(slug.length() - 1);
         }
 
         return slug.toString();

diff --git a/src/test/java/pl/ksdev/slugify/SimpleSlugServiceTest.java b/src/test/java/pl/ksdev/slugify/SimpleSlugServiceTest.java
@@ -36,14 +36,44 @@ public void shouldReturnEmptyString() {
         // given
         String text1 = "";
         String text2 = " @ \n#* \\ $/&) !(&*\r# . ..";
+        String text3 = "*****************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************" +
+            "****************************************************************";
 
         // when
-        String result1 = new SimpleSlugService().slugify("");
-        String result2 = new SimpleSlugService().slugify("");
+        String result1 = new SimpleSlugService().slugify(text1);
+        String result2 = new SimpleSlugService().slugify(text2);
+        String result3 = new SimpleSlugService().slugify(text3);
 
         // then
         assertEquals("", result1);
         assertEquals("", result2);
+        assertEquals("", result3);
     }
 
     @Test