Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy 2 #140

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Proxy 2 #140

merged 2 commits into from
Jan 8, 2025

Conversation

paigerube14
Copy link
Contributor

No description provided.

@paigerube14 paigerube14 force-pushed the proxy_2 branch 2 times, most recently from 097db39 to 2875b9e Compare December 4, 2024 15:07
@tsebastiani tsebastiani force-pushed the proxy_2 branch 10 times, most recently from ce85cc5 to 2de0810 Compare December 10, 2024 11:00
@paigerube14 paigerube14 force-pushed the proxy_2 branch 4 times, most recently from 961383e to 77f5442 Compare December 10, 2024 18:03
Signed-off-by: Paige Patton <[email protected]>
@paigerube14
Copy link
Contributor Author

This pr is ready to go, tested on a private vsphere cluster. This addition does not require any changes on the krkn side

fixes

tests refactoring

linting

test

Signed-off-by: Paige Patton <[email protected]>
@paigerube14
Copy link
Contributor Author

@tsebastiani @chaitanyaenr PTAL, think we can get this merged

Copy link
Contributor

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tsebastiani tsebastiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests succeed, LGTM

@tsebastiani tsebastiani merged commit 45deea2 into main Jan 8, 2025
5 checks passed
@tsebastiani tsebastiani deleted the proxy_2 branch January 8, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants