Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-config-standard #245

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

friederbluemle
Copy link

@friederbluemle friederbluemle commented Jan 20, 2023

This updates eslint-config-standard from major version 15 to 17 (which now requires a new peer dependency eslint-plugin-n, as described in the project's usage instructions).

Also included are a few minor related simplifications in the ESLint and Prettier config:

  • space-before-function-paren is incompatible with Prettier
  • semi: true and singleQuote: false are the default for Prettier, so they do not need to be set explicitly

@kristerkari
Copy link
Owner

Thanks, but I'll just let dependabot handle the updating. It's cleaner that way. :)

Feel free to open another PR if you want some other things than the versions to be fixed/improved.

@friederbluemle
Copy link
Author

Sure thing! I've removed the minor/patch updates to ESLint and Prettier in package.json from this PR. The main thing remaining is the major version update of eslint-config-standard (something that obviously can't be automated, due to the new peer dependency). Since this PR now contains quite a bit less code it should be easier to review. I updated the PR description. Please let me know if I should break it down even more. Thanks!

@friederbluemle friederbluemle changed the title Update ESLint and Prettier Update eslint-config-standard Feb 12, 2023
This is a major version update and requires a new peer dependency
eslint-config-n.
space-before-function-paren is incompatible with Prettier.
semi: true and singleQuote: false are the default for Prettier and do
not need to be set explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants