Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools: Sync configure options #517

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

petk
Copy link
Contributor

@petk petk commented Sep 2, 2024

  • AC_ARG_ENABLE replaced with PHP_ARG_ENABLE
  • checks sorted
  • AS_VAR_IF macros used
  • For checking the Valgrind header, the AC_CHECK_HEADERS is used which defines the HAVE_VALGRIND_MEMCHECK_H preprocessor macro by default
  • The APC_MMAP preprocessor macro is either undefined or defined to 1 so the #if checks are also replaced with #ifdef to not cause possible -Wundef warnings emitted if such compiler configuration is set

- AC_ARG_ENABLE replaced with PHP_ARG_ENABLE
- checks sorted
- AS_VAR_IF macros used
- For checking the Valgrind header, the AC_CHECK_HEADERS is used which
  defines the HAVE_VALGRIND_MEMCHECK_H preprocessor macro by default
- The APC_MMAP preprocessor macro is either undefined or defined to 1
  so the `#if` checks are also replaced with `#ifdef` to not cause
  possible -Wundef warnings emitted if such compiler configuration is
  set
@nikic nikic merged commit f7fe4cc into krakjoe:master Sep 3, 2024
11 of 25 checks passed
@petk petk deleted the patch-configure-options branch September 3, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants