Improve autotools AC_ARG_ENABLE usage #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2016 14:13
Previously, the macros appeared to have the use of "if enabled ; then x ; else y" This is not how autoconf interprets the AC_ARG_ENABLE macro. Instead it is "if present; then x; else y" Now, it uses the result of the AC_ARG_ENABLE to test and act in a true IF
|
@remicollet do you have a build matrix with lots of different configurations by chance ? |
|
I can test on RHEL-6 (the older version for which I build PHP 7) and Fedora 25 (the more recent version) So autoconf 2.63 - 2.69 => OK. But perhaps we should prefer the PHP macros (PHP_ARG_ENABLE, PHP_ARG_WITH) instead of AC ones |
|
I feel unsure about why it used AC ones in the first place ... I'm scared of autotools ... Anyone else got some input ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config.m4 falls into an autotools issue of present/not present vs enabled/disabled described at https://autotools.io/autoconf/arguments.html
Previously, the macros appeared to have the use of "if enabled ; then x ; else y"
This is not how autoconf interprets the AC_ARG_ENABLE macro.
Instead it is "if present; then x; else y"
Now, it uses the result of the AC_ARG_ENABLE to test and act in a true IF.
The apparent desired behavior is preserved.