Raven RawScreen Aspect Fix #546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note that stbar in "Not Adjusted" aspect currently uses settings for "Doom Format"
andrikpowell
force-pushed
the
dsda_raven_rawscreen_aspect_fix
branch
from
76b5de0
to
8b951bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a thing that's bothered me for quite a while is that the "RawScreen"s that Raven uses have only been rendered using the "Not Adjusted" stretch setting... regardless of the stretch settings.
This PR fixes that and the issue mentioned here (#467). They are both related to the same issue in different ways. The problem with the specific issue, was that the "RawScreen" under "Fit to Width" was supposed to fit to width (imagine that), but code was set to prevent that.
Now the "RawScreen"s will look as they should for all three settings: "Not Adjusted", "Doom Format", and "Fit to Width". I will mention that the "RawScreen" code seems a bit WIP, so eventually there may be a better way to approach this further down the line.
One of the reasons the format was previously forced was probably due to the Raven Statusbar not being rendered properly under "Not Adjusted"... But the "RawScreen"s don't have that issue.
I haven't been able to fix the Raven Statusbar for "Not Adjusted", so I have it using the "Doom Format" stretch settings (just as DSDA Doom currently does).