Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPv6 in service account lookups #512

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

jacobtomlinson
Copy link
Member

Closes #511

@jacobtomlinson jacobtomlinson added bug Something isn't working auth Authenticating with Kubernetes labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (87063fc) to head (506f174).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   94.61%   95.09%   +0.47%     
==========================================
  Files          29       30       +1     
  Lines        3141     3998     +857     
==========================================
+ Hits         2972     3802     +830     
- Misses        169      196      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit dd9b2b1 into kr8s-org:main Nov 1, 2024
11 checks passed
@jacobtomlinson jacobtomlinson deleted the ipv6-fix branch November 1, 2024 16:33
@WillDaSilva
Copy link

Thanks for the quick fix @jacobtomlinson! Would you be willing to publish a release with this fix soon? No worries if not, since I've already implemented a workaround in my own code, but it'd be nice if I could remove that workaround.

@jacobtomlinson
Copy link
Member Author

Sure thing! I've tagged v0.18.0 which contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Authenticating with Kubernetes bug Something isn't working kr8s tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when KUBERNETES_SERVICE_HOST env var is an IPv6 address
2 participants