Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyPI version of pytest-kind #269

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jacobtomlinson
Copy link
Member

Pushing to PyPI is currently failing as the pytest-kind dependency is directly pointing to GitHub.

I seem to remember doing this because we needed some unreleased fix from pytest-kind, but that may have been a hangover from dask-kubernetes and no longer needed.

@jacobtomlinson
Copy link
Member Author

jacobtomlinson commented Jan 3, 2024

It looks like the latest tag in the repo was the 22.11.1 release commit so hopefully things should just work as expected.

https://codeberg.org/hjacobs/pytest-kind/commits/branch/main

I think the reason it was pointing to the git URL is because I made a PR in Oct 2021 to make the kind and kubectl versions configurable, but that change didn't get included in a release until August 2022.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc1ecac) 94.71% compared to head (bc2975d) 94.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          27       27           
  Lines        2781     2781           
=======================================
  Hits         2634     2634           
  Misses        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 67c25d2 into kr8s-org:main Jan 3, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the pytest-kind-dep branch January 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant