Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basic authentication #260

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Remove basic authentication #260

merged 2 commits into from
Dec 21, 2023

Conversation

marceloFA
Copy link
Contributor

@marceloFA marceloFA commented Dec 19, 2023

Closes #240

@github-actions github-actions bot added the kr8s label Dec 19, 2023
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute this change. I expect we should see coverage increase because we didn't have any tests for user/pass auth.

I left a couple of comments. Also please be sure to run pre-commit to check the linting.

kr8s/_api.py Outdated Show resolved Hide resolved
kr8s/_auth.py Show resolved Hide resolved
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (530c5c4) 94.58% compared to head (0eeea80) 94.70%.
Report is 2 commits behind head on main.

Files Patch % Lines
kr8s/_auth.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   94.58%   94.70%   +0.12%     
==========================================
  Files          27       27              
  Lines        2751     2739      -12     
==========================================
- Hits         2602     2594       -8     
+ Misses        149      145       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 84ba11b into kr8s-org:main Dec 21, 2023
12 of 13 checks passed
@jacobtomlinson
Copy link
Member

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove basic auth
2 participants