-
Notifications
You must be signed in to change notification settings - Fork 10
Redesigned UI and small code refactoring #24
Conversation
…from MainPage to LightingPage
…n, larger keyboard, tabbed keyboard layers, etc.
…respective pages.
… completely in sync for writing to keyboard.
…er color selection.
…ted LightingPage.xml by accident
The changes are quite long and I will need to go through this PR. I currently do not have access to a Windows 10 machine. I will keep this PR open for the time being. |
I have a pushed a new release based on your changes: https://github.com/kprinssu/anne-keyboard-windows/releases/tag/1.0.4 I will merge your changes into master after a code style check. If anyone else is currently using the 1.0.4 release, please report an issues in this PR. |
It works fine on my PC 👍 . |
Was asked to post bugs I found here from /r/Annepro , sorry if this is not the right section.
The app works surprisingly in Windows 10 Mobile and even lets me sync the Anne Pro using the Lumia 950 XL but unfortunately the UI does not scale down to mobile sized windows. Adding scaling so when the window is resized to a mobile sized window can fix this and add mobile support without even having to do anything else. Other than that everything else seems fine so far. Windows Specifications : |
I cannot add support for Windows 10 mobile due to lack of devices. I will look into the other mentioned bugs. |
@NexuGX
It was my intention to use: https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/color-picker for the color picker, but was not available when I made my PR (and would probably alleviate your problem). The picker I chose was the cleanest looking one I could find without building it myself, but it clearly has some short comings (like displaying the RGB values, but not letting you edit them). If you give me more specifics about the scrolling problem, I can look into fixing it |
What I meant by the color selection not being scrollable is the entire page is offscreen on small displays and there is no way to scroll to get to things like the rgb slider or the button next to it. For the second one I understand, I'm not a UWP dev either, I only know the bare basics of it and very little C# so its understandable why you went with static positioning. |
Redesigned the UI (to fit UWP design) and, as per #23, enlarged keyboard
UI Changes:
Code changes:
** All the connection code is in the MainPage
** Left profile logic is in individual pages for possible future changes splitting lighting/layout profiles
There is still more I would like to do in order to clean up and reuse the code more, but the UI is complete in this PR.