-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades/refactoring #10
base: master
Are you sure you want to change the base?
Conversation
…ixed path to Java executable
… option for docker build
…authenticate/sub/pub, removed unused functions
… sources/resources properties from pom
Made stream name variable
MAINTAINER Bruno De Bus <[email protected]> | ||
|
||
ARG IMAGE_VERSION | ||
|
||
ARG image_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the uppercase ARG names. I believe in docker files it is the more popular style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that it is example code, but it might still be worth it to look at using a logging library iso using print statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the remarks of Rutger about the uppercase IMAGE_VERSION
and the logger.
Hi,
We've been using this repository for onboarding new teams on DSH.
The changes we made to the repo are included in this PR.