Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #739

Open
wants to merge 234 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
234 commits
Select commit Hold shift + click to select a range
db84812
Merge branch 'bcachefs-kill-retry-estale' into HEAD
Oct 11, 2024
40cfa4d
bcachefs: Fix racy use of jiffies
Oct 9, 2024
61b2134
bcachefs: remove superfluous ; after statements
ColinIanKing Oct 7, 2024
cb9d341
bcachefs: bch2_inode_should_have_bp -> bch2_inode_should_have_single_bp
Sep 28, 2024
61bf384
bcachefs: remove_backpointer() now uses dirent_get_by_pos()
Oct 1, 2024
be40eda
bcachefs: __bch2_key_has_snapshot_overwrites uses for_each_btree_key_…
Sep 30, 2024
1ef7af6
bcachefs: rcu_pending: don't invoke __call_rcu() under lock
Sep 22, 2024
bdb3bdc
bcachefs: bch_verbose_ratelimited
Sep 29, 2024
2aa08c4
bcachefs: Pull disk accounting hooks out of trans_commit.c
Oct 1, 2024
6952c5b
bcachefs: Delete dead code
alanskind Sep 27, 2024
cf3d513
bcachefs: move bch2_xattr_handlers to .rodata
bertschingert Sep 14, 2024
8ed4dcb
bcachefs: Remove unnecessary peek_slot()
Sep 24, 2024
250087e
bcachefs: kill btree_trans_restart_nounlock()
Sep 24, 2024
43bf715
docs: filesystems: bcachefs: fixed some spelling mistakes in the bcac…
Sep 12, 2024
0892d51
bcachefs: Remove duplicate included headers
toblux Sep 23, 2024
e475312
bcachefs: Use FOREACH_ACL_ENTRY() macro to iterate over acl entries
toblux Sep 23, 2024
aab94e9
bcachefs: add more path idx debug asserts
Sep 23, 2024
31308cd
bcachefs: bch2_run_explicit_recovery_pass() returns different error w…
Sep 22, 2024
f5037ae
bcachefs: lru, accounting are alloc btrees
Sep 22, 2024
f5e8d02
bcachefs: Add locking for bch_fs.curr_recovery_pass
Sep 22, 2024
771bf65
bcachefs: bch2_btree_lost_data() now uses run_explicit_rceovery_pass_…
Sep 22, 2024
703b8d6
bcachefs: improved bkey_val_copy()
Oct 10, 2024
7d6273c
bcachefs: Factor out jset_entry_log_msg_bytes()
Oct 10, 2024
a1fbdad
bcachefs: better error message in check_snapshot_tree()
Oct 10, 2024
78cf5d1
bcachefs: Avoid bch2_btree_id_str()
Oct 10, 2024
0911548
bcachefs: Refactor new stripe path to reduce dependencies on ec_strip…
Sep 1, 2024
cca1dff
bcachefs: -o norecovery now bails out of recovery earlier
Oct 12, 2024
a99869f
bcachefs: bch2_journal_meta() takes ref on c->writes
Oct 12, 2024
c4bfe70
bcachefs: Fix warning about passing flex array member by value
Oct 12, 2024
b6a562e
bcachefs: Add block plugging to read paths
Oct 15, 2024
ce612d0
bcachefs: Add version check for bch_btree_ptr_v2.sectors_written vali…
Oct 20, 2024
d953b40
bcachefs: Use str_write_read() helper function
toblux Oct 19, 2024
dfce492
bcachefs: Use str_write_read() helper in ec_block_endio()
toblux Oct 20, 2024
342a485
bcachefs: Use str_write_read() helper in write_super_endio()
toblux Oct 26, 2024
caaf273
bcachefs: Annotate struct bucket_gens with __counted_by()
toblux Oct 26, 2024
104688e
bcachefs: avoid 'unsigned flags'
Oct 20, 2024
e86231f
bcachefs: use bch2_data_update_opts_to_text() in trace_move_extent_fa…
Oct 20, 2024
7813e01
bcachefs: bch2_io_opts_fixups()
Oct 20, 2024
88c2604
bcachefs: small cleanup for extent ptr bitmasks
Oct 20, 2024
ef92eb2
bcachefs: kill bch2_bkey_needs_rebalance()
Oct 20, 2024
48cc0c6
bcachefs: kill __bch2_bkey_sectors_need_rebalance()
Oct 20, 2024
875a312
bcachefs: rename bch_extent_rebalance fields to match other opts structs
Oct 20, 2024
bdad263
bcachefs: io_opts_to_rebalance_opts()
Oct 20, 2024
fc23ffb
bcachefs: Add bch_io_opts fields for indicating whether the opts came…
Oct 20, 2024
86066b1
bcachefs: copygc_enabled, rebalance_enabled now opts.h options
Oct 24, 2024
e1d67b5
bcachefs: bch2_prt_csum_opt()
Oct 28, 2024
a5fe1d1
bcachefs: New bch_extent_rebalance fields
Oct 20, 2024
e2aeaaa
bcachefs: bch2_write_inode() now checks for changing rebalance options
Oct 21, 2024
f14488c
bcachefs: get_update_rebalance_opts()
Oct 20, 2024
8aa17c2
bcachefs: Simplify option logic in rebalance
Oct 20, 2024
9cf36d9
bcachefs: Improve trace_rebalance_extent
Oct 26, 2024
f624072
bcachefs: Move bch_extent_rebalance code to rebalance.c
Oct 29, 2024
9e6755d
bcachefs: remove write permission for gc_gens_pos sysfs interface
Oct 29, 2024
3289204
bcachefs: use attribute define helper for sysfs attribute
Oct 29, 2024
0877e53
bcachefs: Add assert for use of journal replay keys for updates
Oct 31, 2024
bf924ef
bcachefs: Kill BCH_TRANS_COMMIT_lazy_rw
Oct 31, 2024
657e123
bcachefs: Improved check_topology() assert
Oct 31, 2024
e17c5f5
bcachefs: Fix unhandled transaction restart in evacuate_bucket()
Nov 8, 2024
58d33a0
bcachefs: Assert we're not in a restart in bch2_trans_put()
Oct 15, 2024
efaa4e4
bcachefs: Better in_restart error
Oct 15, 2024
e398d6f
bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()
Oct 27, 2024
f97b3e7
bcachefs: Assert that we're not violating key cache coherency rules
Oct 26, 2024
9591891
bcachefs: Rename btree_iter_peek_upto() -> btree_iter_peek_max()
Oct 24, 2024
0ad36d9
bcachefs: Simplify btree_iter_peek() filter_snapshots
Oct 25, 2024
2cb0096
bcachefs: Kill unnecessary iter_rewind() in bkey_get_empty_slot()
Oct 26, 2024
45f6674
bcachefs: Move fsck ioctl code to fsck.c
Nov 6, 2024
88c2aa5
bcachefs: add support for true/false & yes/no in bool-type options
Integral-Tech Oct 23, 2024
19128c5
bcachefs: Correct the description of the '--bucket=size' options
Oct 16, 2024
a57150f
bcachefs: Add support for FS_IOC_GETFSUUID
Jul 9, 2024
797a14e
bcachefs: Add support for FS_IOC_GETFSSYSFSPATH
Jul 9, 2024
0fe251f
bcachefs: Removes NULL pointer checks for __filemap_get_folio return …
Sep 24, 2024
db6b114
bcachefs: Remove redundant initialization in bch2_vfs_inode_init()
Sep 27, 2024
c038280
bcachefs: Simplify code in bch2_dev_alloc()
Oct 16, 2024
53f02a6
bcachefs: Don't use page allocator for sb_read_scratch
Nov 8, 2024
a0678f9
bcachefs: Fix shutdown message
Nov 8, 2024
2228901
bcachefs: delete dead code
Nov 12, 2024
7fda5f1
bcachefs: bch2_btree_bit_mod_iter()
Oct 27, 2024
7ad0ba0
bcachefs: Delete dead code from bch2_discard_one_bucket()
Oct 27, 2024
d6ad842
bcachefs: lru errors are expected when reconstructing alloc
Oct 29, 2024
4a37032
bcachefs: Kill FSCK_NEED_FSCK
Oct 29, 2024
b36ff5d
bcachefs: Reserve 8 bits in bch_reflink_p
Oct 29, 2024
6cf666f
bcachefs: Reorganize reflink.c a bit
Oct 31, 2024
df4270c
bcachefs: Don't delete reflink pointers to missing indirect extents
Oct 21, 2024
3de116c
bcachefs: kill inconsistent err in invalidate_one_bucket()
Oct 27, 2024
ecadaf9
bcachefs: rework bch2_bucket_alloc_freelist() freelist iteration
Oct 28, 2024
c51b601
bcachefs: try_alloc_bucket() now uses bch2_check_discard_freespace_key()
Oct 27, 2024
cbc079b
bcachefs: bch2_bucket_do_index(): inconsistent_err -> fsck_err
Oct 27, 2024
a7df326
bcachefs: discard_one_bucket() now uses need_discard_or_freespace_err()
Oct 27, 2024
632bcf3
bcachefs: Implement bch2_btree_iter_prev_min()
Oct 25, 2024
3140d00
bcachefs: peek_prev_min(): Search forwards for extents, snapshots
Oct 26, 2024
59fad23
bcachefs: Delete backpointers check in try_alloc_bucket()
Nov 15, 2024
7fdfb0c
bcachefs: Kill bch2_get_next_backpointer()
Nov 15, 2024
d5b149f
bcachefs: add missing BTREE_ITER_intent
Nov 17, 2024
3c0fc08
bcachefs: compression workspaces should be indexed by opt, not type
Nov 17, 2024
3a18978
bcachefs: Don't use a shared decompress workspace mempool
Nov 15, 2024
b287adb
bcachefs: Don't BUG_ON() when superblock feature wasn't set for compr…
Nov 15, 2024
ed14404
bcachefs: kill bch2_journal_entries_free()
Nov 17, 2024
1d1374a
bcachefs: journal keys: sort keys for interior nodes first
Nov 17, 2024
1a8f5ad
bcachefs: btree_and_journal_iter: don't iterate over too many whiteou…
Nov 17, 2024
92084fe
bcachefs: fix O(n^2) issue with whiteouts in journal keys
Nov 17, 2024
16de129
bcachefs: Fix evacuate_bucket tracepoint
Dec 9, 2024
62b1855
bcachefs: fix bp_pos_to_bucket_nodev_noerror
Nov 15, 2024
3f2e467
bcachefs: check for backpointers to invalid device
Nov 18, 2024
bbc2ccc
bcachefs: bucket_pos_to_bp_end()
Nov 15, 2024
165ca83
bcachefs: Drop swab code for backpointers in alloc keys
Nov 15, 2024
ad58348
bcachefs: bch_backpointer -> bkey_i_backpointer
Nov 15, 2024
283dcbb
bcachefs: Fix check_backpointers_to_extents range limiting
Nov 18, 2024
da89857
bcachefs: kill bch_backpointer.bucket_offset usage
Nov 17, 2024
1f3c4ab
bcachefs: New backpointers helpers
Nov 15, 2024
01d8d04
bcachefs: Can now block journal activity without closing cur entry
Nov 23, 2024
709336f
bcachefs: trivial btree write buffer refactoring
Nov 23, 2024
2c9a60b
bcachefs: Bias reads more in favor of faster device
Nov 23, 2024
4e378ca
bcachefs: discard fastpath now uses bch2_discard_one_bucket()
Nov 22, 2024
0e796cf
bcachefs: btree_write_buffer_flush_seq() no longer closes journal
Apr 23, 2024
2ae6c5e
bcachefs: BCH_ERR_btree_node_read_error_cached
Nov 24, 2024
3ed349d
bcachefs: Use separate rhltable for bch2_inode_or_descendents_is_open()
Nov 25, 2024
f3542de
bcachefs: errcode cleanup: journal errors
Nov 25, 2024
8b53739
bcachefs: disk_accounting: bch2_dev_rcu -> bch2_dev_rcu_noerror
Nov 25, 2024
ba91f39
bcachefs: Fix accounting_read when we rewind
Nov 25, 2024
658ca21
bcachefs: backpointer_to_missing_ptr is now autofix
Nov 25, 2024
3307caf
bcachefs: Fix btree node scan when unknown btree IDs are present
Nov 25, 2024
873a885
bcachefs: Kill bch2_bucket_alloc_new_fs()
Nov 25, 2024
46522a7
bcachefs: Bad btree roots are now autofix
Nov 25, 2024
2d66d31
bcachefs: Fix dup/misordered check in btree node read
Nov 25, 2024
ec3ca7c
bcachefs: Don't try to en/decrypt when encryption not available
Nov 25, 2024
72177d4
bcachefs: Change "disk accounting version 0" check to commit only
Nov 25, 2024
d6dd534
bcachefs: Fix bch2_btree_node_update_key_early()
Nov 26, 2024
839c29d
bcachefs: Go RW earlier, for normal rw mount
Nov 27, 2024
33213a5
bcachefs: Fix null ptr deref in btree_path_lock_root()
Nov 27, 2024
aa492d5
bcachefs: Ignore empty btree root journal entries
Nov 27, 2024
4d13c89
bcachefs: struct bkey_validate_context
Nov 27, 2024
502a010
bcachefs: Make topology errors autofix
Nov 25, 2024
8afb035
bcachefs: BCH_FS_recovery_running
Nov 27, 2024
a5d7cf3
bcachefs: Guard against journal seq overflow
Nov 28, 2024
6248d42
bcachefs: Issue a transaction restart after commit in repair
Nov 28, 2024
fbb140e
bcachefs: Guard against backpointers to unknown btrees
Nov 28, 2024
5a1b4c8
bcachefs: Fix journal_iter list corruption
Nov 28, 2024
1a7e036
bcachefs: add missing printbuf_reset()
Nov 28, 2024
b7b7f5a
bcachefs: mark more errors AUTOFIX
Nov 28, 2024
ca04ac9
bcachefs: Don't error out when logging fsck error
Nov 28, 2024
4223105
bcachefs: do_fsck_ask_yn()
Nov 28, 2024
6efc86f
bcachefs: Check for bucket journal seq in the future
Nov 28, 2024
9d59eb0
bcachefs: Check for inode journal seq in the future
Nov 28, 2024
1b1f862
bcachefs: cryptographic MACs on superblock are not (yet?) supported
Nov 28, 2024
4271983
bcachefs: bch2_trans_relock() is trylock for lockdep
Nov 28, 2024
12b2baa
bcachefs: Check for extent crc uncompressed/compressed size mismatch
Nov 29, 2024
5bb89aa
bcachefs: Don't recurse in check_discard_freespace_key
Nov 29, 2024
9a95640
bcachefs: Add missing parameter description to bch2_bucket_alloc_trans()
Nov 29, 2024
428a2c2
bcachefs: Fix fsck.c build in userspace
Nov 30, 2024
2ab8d31
bcachefs: bch2_inum_to_path()
Sep 28, 2024
67434cd
bcachefs: Convert write path errors to inum_to_path()
Nov 14, 2024
5e41519
bcachefs: list_pop_entry()
Nov 30, 2024
28d5570
bcachefs: bkey_fsck_err now respects errors_silent
Nov 29, 2024
247a12f
bcachefs: If we did repair on a btree node, make sure we rewrite it
Nov 29, 2024
0b5819b
bcachefs: bch2_async_btree_node_rewrites_flush()
Nov 29, 2024
a5b377f
bcachefs: fix bch2_journal_key_insert_take() seq
Dec 1, 2024
030d6eb
bcachefs: Improve "unable to allocate journal write" message
Dec 1, 2024
e37f428
bcachefs: Fix allocating too big journal entry
Dec 3, 2024
8a27135
bcachefs: BCACHEFS_PATH_TRACEPOINTS should depend on TRACING
geertu Dec 3, 2024
354ae85
bcachefs: rcu_pending now works in userspace
Dec 4, 2024
3ac87fa
bcachefs: logged ops only use inum 0 of logged ops btree
Dec 2, 2024
52a0da6
bcachefs: Simplify disk accounting validate late
Dec 4, 2024
fdfafff
bcachefs: Advance to next bp on BCH_ERR_backpointer_to_overwritten_bt…
Dec 4, 2024
2a21c9d
bcachefs: trace_accounting_mem_insert
Dec 4, 2024
fe23688
bcachefs: Silence "unable to allocate journal write" if we're already RO
Dec 4, 2024
fd2a164
bcachefs: BCH_ERR_insufficient_journal_devices
Dec 4, 2024
effc7a1
bcachefs: Fix failure to allocate journal write on discard retry
Dec 4, 2024
0a1a039
bcachefs: dev_alloc_list.devs -> dev_alloc_list.data
Dec 5, 2024
70feb56
bcachefs: Journal write path refactoring, debug improvements
Dec 4, 2024
8ea098f
bcachefs: Call bch2_btree_lost_data() on btree read error
Dec 5, 2024
61ab7cb
bcachefs: Make sure __bch2_run_explicit_recovery_pass() signals to re…
Dec 5, 2024
cea5427
bcachefs: Don't call bch2_btree_interior_update_will_free_node() unti…
Dec 5, 2024
7dacc22
bcachefs: kill flags param to bch2_subvolume_get()
Dec 5, 2024
0ecfac8
bcachefs: factor out str_hash.c
Dec 5, 2024
6315b49
bcachefs: Journal space calculations should skip durability=0 devices
Dec 5, 2024
8ceb549
bcachefs: fix bch2_btree_node_header_to_text() format string
Dec 7, 2024
2c77b17
bcachefs: Mark more errors autofix
Dec 7, 2024
e0e0d73
bcachefs: Minor bucket alloc optimization
Dec 7, 2024
05cb2a4
lib min_heap: Switch to size_t
Dec 7, 2024
488249b
bcachefs: Use a heap for handling overwrites in btree node scan
Dec 7, 2024
e8d6041
bcachefs: Plumb bkey_validate_context to journal_entry_validate
Dec 8, 2024
8f367a5
bcachefs: Don't add unknown accounting types to eytzinger tree
Dec 5, 2024
f3b4692
bcachefs: Set bucket needs discard, inc gen on empty -> nonempty tran…
Dec 8, 2024
c106801
bcachefs: bch2_journal_noflush_seq() now takes [start, end)
Dec 8, 2024
d7f6bec
bcachefs: Fix reuse of bucket before journal flush on multiple empty …
Dec 7, 2024
0939c61
bcachefs: Don't start rewriting btree nodes until after journal replay
Dec 9, 2024
2a11567
bcachefs: Kill unnecessary mark_lock usage
Dec 8, 2024
c5022a7
bcachefs: kill sysfs internal/accounting
Dec 9, 2024
5cd80c5
bcachefs: Use proper errcodes for inode unpack errors
Dec 9, 2024
90ae216
bcachefs: Don't BUG_ON() inode unpack error
Dec 9, 2024
eccc694
bcachefs: bch2_str_hash_check_key() now checks inode hash info
Dec 9, 2024
d54b4f3
bcachefs: bch2_check_key_has_snapshot() prints btree id
Dec 9, 2024
152c28e
bcachefs: bch2_snapshot_exists()
Dec 9, 2024
42c1d1a
bcachefs: trace_write_buffer_maybe_flush
Dec 10, 2024
cee2a47
bcachefs: Add empty statement between label and declaration in check_…
nathanchance Dec 10, 2024
bb4ae14
bcachefs: Refactor c->opts.reconstruct_alloc
Dec 10, 2024
cf44b08
bcachefs: check_indirect_extents can run online
Dec 9, 2024
52ee09e
bcachefs: tidy up __bch2_btree_iter_peek()
Dec 12, 2024
eece590
bcachefs: tidy btree_trans_peek_journal()
Dec 13, 2024
bf5ec9b
bcachefs: Fix btree_trans_peek_key_cache() BTREE_ITER_all_snapshots
Dec 12, 2024
760fbaf
bcachefs: Fix key cache + BTREE_ITER_all_snapshots
Dec 13, 2024
395d7f5
bcachefs: alloc_data_type_set() happens in alloc trigger
Dec 12, 2024
75bca41
bcachefs: Don't run overwrite triggers before insert
Dec 12, 2024
46f92a9
bcachefs: Kill equiv_seen arg to delete_dead_snapshots_process_key()
Dec 12, 2024
7c410e2
bcachefs: Snapshot deletion no longer uses snapshot_t->equiv
Dec 12, 2024
5d9b21a
bcachefs: Kill snapshot_t->equiv
Dec 12, 2024
50dd5a0
bcachefs: bch2_trans_log_msg()
Dec 12, 2024
dd0d1ff
bcachefs: Log message in journal for snapshot deletion
Dec 12, 2024
0694b43
bcachefs: trace_key_cache_fill
Dec 13, 2024
8062b34
bcachefs: bch2_btree_path_peek_slot() doesn't return errors
Dec 13, 2024
ab7eb8e
bcachefs: bcachefs_metadata_version_backpointer_bucket_gen
Nov 17, 2024
c6b74e6
bcachefs: bcachefs_metadata_version_disk_accounting_big_endian
Nov 29, 2024
70e1e1a
bcachefs: bch2_extent_ptr_to_bp() no longer depends on device
Nov 18, 2024
78daf5e
bcachefs: kill __bch2_extent_ptr_to_bp()
Nov 17, 2024
9364e11
bcachefs: Add write buffer flush param to backpointer_get_key()
Nov 15, 2024
cbe8afd
bcachefs: check_extents_to_backpointers() now only checks buckets wit…
Nov 15, 2024
19b148f
bcachefs: bch2_backpointer_get_key() now repairs dangling backpointers
Nov 12, 2024
ae7a394
bcachefs: better backpointer_target_not_found() error message
Dec 10, 2024
a33c661
bcachefs: Only run check_backpointers_to_extents in debug mode
Nov 15, 2024
a06f09e
bcachefs: BCH_SB_VERSION_INCOMPAT
Nov 12, 2024
710fb4e
bcachefs: bcachefs_metadata_version_reflink_p_may_update_opts
Nov 7, 2024
7fa06b9
bcachefs: Option changes now get propagated to reflinked data
Oct 20, 2024
b4f1b7e
bcachefs: bcachefs_metadata_version_inode_depth
Aug 3, 2023
7dbe48b
bcachefs: bcachefs_metadata_version_persistent_inode_cursors
Dec 2, 2024
10e485b
bcachefs: bcachefs_metadata_version_autofix_errors
Dec 10, 2024
92b9e40
bcachefs: add counter_flags for counters
Nov 12, 2024
959dbb0
bcachefs: better check_bp_exists() error message
Dec 12, 2024
5208484
bcachefs: Drop racy warning
Dec 15, 2024
83fa58a
bcachefs: Drop redundant "read error" call from btree_gc
Dec 15, 2024
989229d
bcachefs: kill __bch2_btree_iter_flags()
Dec 15, 2024
7b5ddd2
bcachefs: Write lock btree node in key cache fills
Jun 8, 2024
b5677d4
bcachefs: Handle -BCH_ERR_need_mark_replicas in gc
Dec 16, 2024
ca2e7a3
bcachefs: Fix assert for online fsck
Dec 16, 2024
d581cdb
Fix typos
Gelma Dec 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/filesystems/bcachefs/CodingStyle.rst
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ even better as a code comment.
A good code comment is wonderful, but even better is the comment that didn't
need to exist because the code was so straightforward as to be obvious;
organized into small clean and tidy modules, with clear and descriptive names
for functions and variable, where every line of code has a clear purpose.
for functions and variables, where every line of code has a clear purpose.
4 changes: 2 additions & 2 deletions fs/bcachefs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ config BCACHEFS_ERASURE_CODING
depends on BCACHEFS_FS
select QUOTACTL
help
This enables the "erasure_code" filesysystem and inode option, which
This enables the "erasure_code" filesystem and inode option, which
organizes data into reed-solomon stripes instead of ordinary
replication.

Expand Down Expand Up @@ -89,7 +89,7 @@ config BCACHEFS_SIX_OPTIMISTIC_SPIN

config BCACHEFS_PATH_TRACEPOINTS
bool "Extra btree_path tracepoints"
depends on BCACHEFS_FS
depends on BCACHEFS_FS && TRACING
help
Enable extra tracepoints for debugging btree_path operations; we don't
normally want these enabled because they happen at very high rates.
Expand Down
1 change: 1 addition & 0 deletions fs/bcachefs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ bcachefs-y := \
siphash.o \
six.o \
snapshot.o \
str_hash.o \
subvolume.o \
super.o \
super-io.o \
Expand Down
16 changes: 6 additions & 10 deletions fs/bcachefs/acl.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ static struct posix_acl *bch2_acl_from_disk(struct btree_trans *trans,
return NULL;

acl = allocate_dropping_locks(trans, ret,
posix_acl_alloc(count, _gfp));
posix_acl_alloc(count, GFP_KERNEL));
if (!acl)
return ERR_PTR(-ENOMEM);
if (ret) {
Expand Down Expand Up @@ -184,11 +184,6 @@ static struct posix_acl *bch2_acl_from_disk(struct btree_trans *trans,
return ERR_PTR(-EINVAL);
}

#define acl_for_each_entry(acl, acl_e) \
for (acl_e = acl->a_entries; \
acl_e < acl->a_entries + acl->a_count; \
acl_e++)

/*
* Convert from in-memory to filesystem representation.
*/
Expand All @@ -199,11 +194,11 @@ bch2_acl_to_xattr(struct btree_trans *trans,
{
struct bkey_i_xattr *xattr;
bch_acl_header *acl_header;
const struct posix_acl_entry *acl_e;
const struct posix_acl_entry *acl_e, *pe;
void *outptr;
unsigned nr_short = 0, nr_long = 0, acl_len, u64s;

acl_for_each_entry(acl, acl_e) {
FOREACH_ACL_ENTRY(acl_e, acl, pe) {
switch (acl_e->e_tag) {
case ACL_USER:
case ACL_GROUP:
Expand Down Expand Up @@ -241,7 +236,7 @@ bch2_acl_to_xattr(struct btree_trans *trans,

outptr = (void *) acl_header + sizeof(*acl_header);

acl_for_each_entry(acl, acl_e) {
FOREACH_ACL_ENTRY(acl_e, acl, pe) {
bch_acl_entry *entry = outptr;

entry->e_tag = cpu_to_le16(acl_e->e_tag);
Expand Down Expand Up @@ -427,7 +422,8 @@ int bch2_acl_chmod(struct btree_trans *trans, subvol_inum inum,
if (ret)
goto err;

ret = allocate_dropping_locks_errcode(trans, __posix_acl_chmod(&acl, _gfp, mode));
ret = allocate_dropping_locks_errcode(trans,
__posix_acl_chmod(&acl, GFP_KERNEL, mode));
if (ret)
goto err;

Expand Down
Loading