bcachefs: improve "no device to read from" message

koverstreet · Sep 7, 2024 · 92dc188 · 92dc188
1 parent 3e45aac
commit 92dc188
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/fs/bcachefs/io_read.c b/fs/bcachefs/io_read.c
@@ -869,9 +869,15 @@ int __bch2_read_extent(struct btree_trans *trans, struct bch_read_bio *orig,
 		goto hole;
 
 	if (pick_ret < 0) {
+		struct printbuf buf = PRINTBUF;
+		bch2_bkey_val_to_text(&buf, c, k);
+
 		bch_err_inum_offset_ratelimited(c,
 				read_pos.inode, read_pos.offset << 9,
-				"no device to read from");
+				"no device to read from: %s\n  %s",
+				bch2_err_str(pick_ret),
+				buf.buf);
+		printbuf_exit(&buf);
 		goto err;
 	}