Nixos tests #299
Open
Nixos tests #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmuehlbacher
force-pushed
the
nixos-tests
branch
7 times, most recently
from
fe1a491 to
d750e28
Compare
tmuehlbacher
force-pushed
the
nixos-tests
branch
2 times, most recently
from
fd10954 to
cc0c05d
Compare
toastal
reviewed
Jun 22, 2024
toastal
reviewed
Jun 22, 2024
toastal
reviewed
Jun 22, 2024
toastal
reviewed
Jun 22, 2024
tmuehlbacher
force-pushed
the
nixos-tests
branch
from
cc0c05d to
3ecfab7
Compare
|
Just btw, I am not sure that Kent will merge this. For me it was useful already but the larger idea is to use some of this stuff with the NixOS testing library for ktest. I have some ideas for that and this was helpful to familiarize myself with nixos testing but it's still a larger undertaking for me that I am just starting with. :) |
tmuehlbacher
force-pushed
the
nixos-tests
branch
2 times, most recently
from
1603b73 to
a062514
Compare
Use nixos-test scaffolding to spawn VMs and run any scripts in `checks/*.sh` as tests inside of the VM. This should lessen the risk of any obvious breakage in the CI but needs more and better tests to cover more commands. Signed-off-by: Thomas Mühlbacher <[email protected]>
This in particular speeds up the dev/run/debug cycle for writing more tests. Without this, the actual bcachefs-tools package will be rebuilt by Nix all the time because of changes to files that are tracked by git. Even when it's changes in parts that aren't relevant to that package build such as `checks/*`. Signed-off-by: Thomas Mühlbacher <[email protected]>
This reverts commit 88aa61e. No longer required because the added nixos-tests check already causes the package to be built now. Signed-off-by: Thomas Mühlbacher <[email protected]>
The second mount works if the device is already part of the `bcachefs format` but fails if it's added afterwards. In particular the `blkid` output is interesting.
tmuehlbacher
force-pushed
the
nixos-tests
branch
from
a062514 to
0e0be9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checks directory with bash scripts to run inside of a VM for testing the functionality of bcachefs-tools. Useful for regression testing but needs to be fleshed out more to cover all of the commands.
Supersedes #296 (just shouldn't even have put wip/ into the branch name in the first place.)