mount: print a helpful error message

Just returning a failure exit status makes it hard to tell what the actual issue was. Instead, the mount command now also provides some textual output. See #308 for an example where mount does not provide any helpful output, even with BCACHEFS_LOG=trace enabled. Signed-off-by: Florian Schmaus <[email protected]>
koverstreet · Oct 25, 2024 · 9ed0f3f · 9ed0f3f
1 parent 4f9293b
commit 9ed0f3f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/commands/mount.rs b/src/commands/mount.rs
@@ -10,7 +10,7 @@ use std::{
 use anyhow::{ensure, Result};
 use bch_bindgen::{bcachefs, bcachefs::bch_sb_handle, opt_set, path_to_cstr};
 use clap::Parser;
-use log::{debug, info};
+use log::{debug, error, info};
 use uuid::Uuid;
 
 use crate::{
@@ -385,6 +385,9 @@ pub fn mount(mut argv: Vec<String>, symlink_cmd: Option<&str>) -> std::process::
 
     match cmd_mount_inner(&cli) {
         Ok(_)   => std::process::ExitCode::SUCCESS,
-        Err(_)   => std::process::ExitCode::FAILURE,
+        Err(e)   => {
+            error!("Mount failed: {e}");
+            std::process::ExitCode::FAILURE
+        }
     }
 }