Skip to content

Commit

Permalink
Fix calling convention mismatch in GC callouts (dotnet#110685)
Browse files Browse the repository at this point in the history
Fixes dotnet#110607.

The native side expected fastcall, managed side didn't.

Filed dotnet#110684 on the test hole. We would have caught it during x86 bringup if this had _any_ tests since this is a guaranteed stack corruption and crash.
  • Loading branch information
MichalStrehovsky authored Dec 16, 2024
1 parent 3aa1ec5 commit 20dc146
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime/RestrictedCallouts.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,6 @@ class RestrictedCallouts
static CrstStatic s_sLock;

// Prototypes for the callouts.
typedef void (F_CALL_CONV * GcRestrictedCallbackFunction)(uint32_t uiCondemnedGeneration);
typedef void (* GcRestrictedCallbackFunction)(uint32_t uiCondemnedGeneration);
typedef CLR_BOOL (* HandleTableRestrictedCallbackFunction)(Object * pObject);
};

0 comments on commit 20dc146

Please sign in to comment.