Skip to content

Commit

Permalink
[wasm] Fix performance-setup.sh to track change in BDN (dotnet#92067)
Browse files Browse the repository at this point in the history
* [wasm] Fix performance-setup.sh to track change in BDN

`dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via
dotnet/performance#3331 . And that bdn update
includes dotnet/BenchmarkDotNet#2375, which
subtly changes how the arguments get parsed, and breaks the existing
scripts:

```
$ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks"
$ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ...
MicroBenchmarks 1.0.0-dev
© Microsoft Corporation. All rights reserved.

ERROR(S):
  Option 'experimental-wasm-eh --expose_wasm --module' is unknown.
```

Fixes dotnet#92066 .

* fix command line
  • Loading branch information
radical authored Sep 14, 2023
1 parent 650eec9 commit 088f162
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eng/testing/performance/performance-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then
fi

# Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine $javascript_engine_path --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine $javascript_engine_path \\\"--wasmArgs=$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
if [[ "$wasmaot" == "true" ]]; then
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600"
fi
Expand Down

0 comments on commit 088f162

Please sign in to comment.