Skip to content

Commit

Permalink
squash w/ [3902] Replace GenQuery1 ad-hoc parsing code with flex/biso…
Browse files Browse the repository at this point in the history
…n parser. Expand comment about generation of queries file.
  • Loading branch information
korydraughn committed Dec 16, 2024
1 parent 78d4a43 commit a02ec4c
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions unit_tests/src/test_genquery1_flex_bison_parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ TEST_CASE("GenQuery1 flex bison parser maintains backward compatibility with ori
// input struct.

// Open file containing list of GenQuery1 query strings. This list of queries was
// produced from the test suite.
// generated from the unit and core test suites using the following steps:
//
// 1. Modify fillGenQueryInpFromStrCond() so that it appends each query string to a local file.
// The file is written to a directory which is automatically captured by the testing
// environment (e.g. /var/log/irods).
// 2. If the tests were run in parallel, take each file (now stored on the host) and concatenate them.
// 3. Clean up file contents (i.e. dedup lines, etc).
const auto file_path = irods::get_irods_home_directory() / "unit_tests/genquery1_backwards_compatibility_queries.txt";
std::ifstream in{file_path.generic_string()};
REQUIRE(in);
Expand Down Expand Up @@ -429,4 +435,4 @@ auto separateSelFuncFromAttr(char* t, char** aggOp, char** colNm) -> int
}
*s = '\0';
return 0;
}
} // separateSelFuncFromAttr

0 comments on commit a02ec4c

Please sign in to comment.