Skip to content

Commit

Permalink
squash. json schema reordering and TODO for default path for main ser…
Browse files Browse the repository at this point in the history
…ver pid.
  • Loading branch information
korydraughn committed Oct 18, 2024
1 parent 76f8d32 commit 8550a6c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
15 changes: 9 additions & 6 deletions schemas/configuration/v4/server_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,22 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"properties": {
"ips_data_directory": {"type": "string"},
"stacktrace_directory": {"type": "string"},
"json_schema_file": {"type": "string"},
"environment_json_schema_file": {"type": "string"},

"ips_data_directory": {"type": "string"},
"stacktrace_directory": {"type": "string"},

"msiExecCmd_bin_directory": {"type": "string"},
"plugin_directory": {"type": "string"},
"home_directory": {"type": "string"},
"version_file": {"type": "string"},

"graceful_shutdown_timeout_in_seconds": {
"type": "integer",
"minimum": 0,
"default": 30
},
"msiExecCmd_bin_directory": {"type": "string"},
"plugin_directory": {"type": "string"},
"home_directory": {"type": "string"},
"version_file": {"type": "string"},

"directories": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion server/main_server/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ int main(int _argc, char* _argv[])
// Perhaps daemonization means there's only one instance running on the machine?
// What if the pidfile name was derived from the config file path? Only one instance can work.
// But, what if server redirection is disabled by the admin?
std::string pid_file = "/var/run/irods.pid";
std::string pid_file = "/var/run/irods.pid"; // TODO Derive from default root path.
if (const auto iter = vm.find("pid-file"); std::end(vm) != iter) {
pid_file = std::move(iter->second.as<std::string>());
}
Expand Down

0 comments on commit 8550a6c

Please sign in to comment.