only converting strings to dates if they parse as dates

koopjs · Jun 24, 2015 · fc1664f · fc1664f
1 parent a7f0a7d
commit fc1664f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/FeatureServices.js b/lib/FeatureServices.js
@@ -60,7 +60,7 @@ module.exports = {
       type = (( idField && key === idField ) ? 'esriFieldTypeOID' : (self.fieldType( props[ key ])||'esriFieldTypeString') );
 
       // check for a date; set type
-      if ( new Date(props[ key ]) !== "Invalid Date" && !isNaN(new Date(props[ key ])) ) {
+      if ( typeof props[ key ] === 'string' && (new Date(props[ key ]) !== "Invalid Date" && !isNaN(new Date(props[ key ])) )) {
         type = 'esriFieldTypeDate';
       }
 

diff --git a/test/models/featureservice-test.js b/test/models/featureservice-test.js
@@ -35,7 +35,8 @@ describe('FeatureServices Model', function(){
       var input = {
         propInt: 10,
         propFloat:10.1,
-        propString:'Awesome'
+        propString:'Awesome',
+        propDate: 'Wed Jun 24 2015 08:18:24'
       };
       var fieldObj = fs.fields( input ),
         fields = fieldObj.fields;
@@ -57,10 +58,11 @@ describe('FeatureServices Model', function(){
             f.should.have.property('type');
             f.should.have.property('name');
             f.should.have.property('alias');
-          });
+          })
           fields[0].type.should.equal('esriFieldTypeInteger'); 
           fields[1].type.should.equal('esriFieldTypeDouble'); 
           fields[2].type.should.equal('esriFieldTypeString'); 
+          fields[3].type.should.equal('esriFieldTypeDate'); 
           done();
       });
     });