Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates new deploy #5

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Updates new deploy #5

merged 8 commits into from
Jun 18, 2024

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested a review from a team as a code owner June 4, 2024 13:36
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sample-app-preview-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 6:00am

Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have removed the deployment step from the CI but didn't add a replacement. How do you plan deploying the app? I didn't notice the Vercel deployment.

src/constants/routePaths.ts Show resolved Hide resolved
src/components/ErrorPage.tsx Outdated Show resolved Hide resolved
src/repositories/previewApiKeyRepository.ts Outdated Show resolved Hide resolved
src/repositories/projectContainerRepository.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
JiriLojda
JiriLojda previously approved these changes Jun 11, 2024
package.json Outdated
@@ -44,6 +45,7 @@
]
},
"devDependencies": {
"dprint": "^0.46.2",
"gh-pages": "^2.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can remove this dependency now.

@JiriLojda
Copy link
Member

Would you also please add the devrel team into code owners so that my reviews here matter? 😄

@IvanKiral IvanKiral merged commit 92a11c7 into master Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants