-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates new deploy #5
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have removed the deployment step from the CI but didn't add a replacement. How do you plan deploying the app? I didn't notice the Vercel deployment.
e0ba0a9
to
84a7c66
Compare
84a7c66
to
a5dcb76
Compare
package.json
Outdated
@@ -44,6 +45,7 @@ | |||
] | |||
}, | |||
"devDependencies": { | |||
"dprint": "^0.46.2", | |||
"gh-pages": "^2.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we can remove this dependency now.
Would you also please add the devrel team into code owners so that my reviews here matter? 😄 |
Motivation
Which issue does this fix? Fixes #
issue number
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?