Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL-294 - upgrade to MAPI v2 #67

Closed
wants to merge 91 commits into from
Closed

KCL-294 - upgrade to MAPI v2 #67

wants to merge 91 commits into from

Conversation

Simply007
Copy link
Contributor

@Simply007 Simply007 commented Jun 2, 2021

Motivation

Fixes #50 and #53

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@gormal gormal assigned gormal and unassigned ghost Jun 11, 2021
@gormal
Copy link
Contributor

gormal commented Jun 11, 2021

We won't transform dynamic elements to strongly typed models as of now. We keep them dynamic and use some kind of workaround in order to be able to access them by codename.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #67 (d004693) into master (e0dafcb) will increase coverage by 5.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   69.13%   74.50%   +5.36%     
==========================================
  Files          57      142      +85     
  Lines        1241     2067     +826     
  Branches      159      220      +61     
==========================================
+ Hits          858     1540     +682     
- Misses        304      394      +90     
- Partials       79      133      +54     
Impacted Files Coverage Δ
...co.Kontent.Management/Models/Assets/AssetFolder.cs 0.00% <0.00%> (-100.00%) ⬇️
...t/Models/Assets/AssetListingResponseServerModel.cs 25.00% <0.00%> (-37.50%) ⬇️
...ico.Kontent.Management/Models/Assets/AssetModel.cs 92.30% <0.00%> (-7.70%) ⬇️
...odules/ActionInvoker/DynamicObjectJsonConverter.cs 78.37% <0.00%> (-5.50%) ⬇️
...Kontent.Management/Models/ProjectReport/Project.cs 100.00% <0.00%> (ø)
...ontent.Management/Models/Items/ContentItemModel.cs 100.00% <0.00%> (ø)
...ntent.Management/Models/Assets/AssetDescription.cs 100.00% <0.00%> (ø)
...ntent.Management/Models/Assets/AssetUpsertModel.cs 100.00% <0.00%> (ø)
....Management/Models/Items/ContentItemCreateModel.cs 100.00% <0.00%> (ø)
....Management/Models/Items/ContentItemUpsertModel.cs 100.00% <0.00%> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0dafcb...d004693. Read the comment docs.

Copy link
Contributor Author

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just market some places, that needs to be verified.

Simply007 and others added 6 commits July 22, 2021 20:31
# Conflicts:
#	Kentico.Kontent.Management.Tests/Data/ComplexTestModel.cs
#	Kentico.Kontent.Management.Tests/ModelBuildersTests/ModelProviderTests.cs
@Simply007 Simply007 marked this pull request as ready for review October 12, 2021 12:21
@Simply007 Simply007 requested a review from gormal as a code owner October 12, 2021 12:21
@Simply007 Simply007 requested a review from a team October 12, 2021 12:21
@Simply007 Simply007 marked this pull request as draft October 12, 2021 12:21
@Simply007
Copy link
Contributor Author

Closing the pull request draft.

We will work on vNext branch until the version is stable and ready for the final release.

All issues to be covered in this version is in vNext milestone

@Simply007 Simply007 closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management API v2
2 participants