-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KCL-294 - upgrade to MAPI v2 #67
Conversation
project ID a9931a80-9af4-010b-0590-ecb1273cf1b8
We won't transform |
V next - switch already implemented endpoint to V2 and fix tests
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 69.13% 74.50% +5.36%
==========================================
Files 57 142 +85
Lines 1241 2067 +826
Branches 159 220 +61
==========================================
+ Hits 858 1540 +682
- Misses 304 394 +90
- Partials 79 133 +54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just market some places, that needs to be verified.
Kentico.Kontent.Management.Tests/ModelBuildersTests/ModelProviderTests.cs
Outdated
Show resolved
Hide resolved
Kentico.Kontent.Management/Modules/ActionInvoker/DynamicObjectJsonConverter.cs
Outdated
Show resolved
Hide resolved
Kentico.Kontent.Management.Tests/Kentico.Kontent.Management.Tests.csproj
Show resolved
Hide resolved
# Conflicts: # Kentico.Kontent.Management.Tests/Data/ComplexTestModel.cs # Kentico.Kontent.Management.Tests/ModelBuildersTests/ModelProviderTests.cs
Kentico.Kontent.Management/Models/Types/Elements/MultipleChoiceElementMetadataModel.cs
Show resolved
Hide resolved
Closing the pull request draft. We will work on All issues to be covered in this version is in vNext milestone |
Motivation
Fixes #50 and #53
Try to remove custom custom serializer -covertToDynamicObject
,DynamicObjectJsonConverter
(Unable to send a value of 0 for decimal element #29 - works in Management v2 - validate with strongly typed models)Add collection identifierdynamic
element to Strongly type models (value based on Generic element, reference object is a POCO class)Kentico.Kontent.Management.Models.*
- specificallyKentico.Kontent.Management.Models.Items
->Kentico.Kontent.Management.Models.Identifires
and revalidate everything else.Reference
LanguageVariant
as in https://github.com/Kentico/kontent-management-sdk-js/blob/master/lib/models/language-variants/language-variant.models.ts#L19Checklist
How to test
If manual testing is required, what are the steps?