add ability to override default template authorizers.xml #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like a good idea, but maybe you could add a concrete use case example in the documentation (in the tasks section) ? |
Definitely! |
|
@erdrix Let me know if the doc explaining this feature is sufficient. |
erdrix
approved these changes
Apr 20, 2022
erdrix
added a commit
that referenced
this pull request
Aug 3, 2022
add ability to override default template authorizers.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This is an attempt at adding support for overriding the default authorizer configuration.
Adds new optional
ReadOnlyConfig.AuthorizerConfigwith two properties:ReplaceTemplateConfigMapReplaceTemplateSecretConfigThese are ConfigMap or Secret refs to override the default
authorizers.xmltemplate. The docs clarify this, but the order of precedence follows similar conventions for other configurations, such as the logback configuration which this was based on:Secret > ConfigMap > defaultThe purpose of this PR is to configure a custom authorizer, userGroupProvider, and accessPolicyProvider.
Why?
It's not possible to configure an authorizer other than
managed-authorizeroruserGroupProvider/accessPolicyProviderother than the file-based ones.Checklist
To Do