Added oidc Configuration section and operator management #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerla
force-pushed
the
feat/oidcConfiguration
branch
from
d2fcee2 to
36d95aa
Compare
mh013370
reviewed
Sep 25, 2024
| // +kubebuilder:default:=false | ||
| // +optional | ||
| Enabled bool `json:"enabled"` | ||
| // authorizerEnabled specifies if the cluster should use use the single-user-authorizer instead of the managed-authorizer |
There was a problem hiding this comment.
Can you please update these comments to correctly describe the variables?
mh013370
reviewed
Sep 25, 2024
| @@ -162,6 +176,7 @@ func (r *Reconciler) getNifiPropertiesConfigString(nConfig *v1.NodeConfig, id in | |||
| // | |||
| "LdapConfiguration": r.NifiCluster.Spec.LdapConfiguration, | |||
| "SingleUserConfiguration": r.NifiCluster.Spec.SingleUserConfiguration, | |||
| "OidcConfiguration": r.NifiCluster.Spec.OidcConfiguration, | |||
There was a problem hiding this comment.
Can you please correct the tab spacing for all of these?
|
A few of things:
|
mh013370
reviewed
Sep 25, 2024
| Name: OidcConfiguration.SecretRef.Name, | ||
| NameSpace: OidcConfiguration.SecretRef.NameSpace, | ||
| }, | ||
| Key: clientSecret, |
There was a problem hiding this comment.
Can you please document (ad nauseum) what the key in the secret should be for the referenced secret? This should be documented on the website documentation, in nificluster_types.go, and in any comment where is makes sense. This way, it's very clear what the secret should contain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Read new section oidcConfiguration from Values.yaml and inject it into nifi.properties file
Why?
Fix the feature request #463
Checklist
To Do