Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/NifiDataflowOrganizer] Implementation of NifiDataflowOrganizer controller #264

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented May 12, 2023

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Add new resource to create organize your dataflows in NiFi by grouping them.

Why?

To automate the positioning of the dataflows according to others in the same group.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@mh013370
Copy link
Member

This is an interesting idea and i definitely understand the desire for the feature. I'm wondering if this is something the operator should just do by default without needing a new CRD to accomplish it.

Do you think these groupings could be expressed as a part of the NifiDataflow configuration? The operator could interpret these configs and do the same type of grouping.

What do you think? My only concern is that this CRD seems mostly for cosmetic reasons and not functional.

@juldrixx
Copy link
Contributor Author

This is an interesting idea and i definitely understand the desire for the feature. I'm wondering if this is something the operator should just do by default without needing a new CRD to accomplish it.

Do you think these groupings could be expressed as a part of the NifiDataflow configuration? The operator could interpret these configs and do the same type of grouping.

What do you think? My only concern is that this CRD seems mostly for cosmetic reasons and not functional.

I totally agree, but I can't figure out how. In a group, you can specify a color, a position, a name, etc., but if I want to do it directly in the NiFiDataflow resource, how can I do it? And where do I save the information of label, in which resource status?
May be the operator should create a configmap resource to save the information? I'm full of questions 😄

@mh013370
Copy link
Member

This is an interesting idea and i definitely understand the desire for the feature. I'm wondering if this is something the operator should just do by default without needing a new CRD to accomplish it.
Do you think these groupings could be expressed as a part of the NifiDataflow configuration? The operator could interpret these configs and do the same type of grouping.
What do you think? My only concern is that this CRD seems mostly for cosmetic reasons and not functional.

I totally agree, but I can't figure out how. In a group, you can specify a color, a position, a name, etc., but if I want to do it directly in the NiFiDataflow resource, how can I do it? And where do I save the information of label, in which resource status? May be the operator should create a configmap resource to save the information? I'm full of questions 😄

Let me give this some thought and come up with a proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants