Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: expand helm capabilities value #340

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Chore: expand helm capabilities value #340

merged 2 commits into from
Nov 13, 2024
+31 −10

Conversation

Moran-k
Copy link
Contributor

@Moran-k Moran-k commented Nov 13, 2024 •
edited
Loading

Motivation

This pull request updates the Helm capabilities configuration for the Komodor agent chart to allow the separation of read/write permissions.

The changes include modifying the structure of the Helm capabilities in the configuration files, updating the relevant templates, and ensuring backward compatibility with previous configurations.

Changelog

  • Changed capabilities.helm from a boolean to an object with enabled and readonly properties in values.yaml.
  • Updated the README.md to reflect the new structure of the Helm capabilities configuration.

Default values

capabilities:
  helm:
    enabled: true
    readonly: false

@Moran-k
Copy link
Contributor Author

Moran-k commented Nov 13, 2024

CU-86c0zvcpw

@komodor-github-warden
Copy link

Linked task to ClickUp!
Go check it out and add some info: CU-86c0zvcpw

@Moran-k Moran-k requested a review from a team November 13, 2024 10:34
nirbenator
nirbenator approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@nirbenator nirbenator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

charts/komodor-agent/templates/_migrations.tpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@Moran-k Moran-k merged commit 55ef73c into master Nov 13, 2024
2 checks passed
@Moran-k Moran-k deleted the chore/expand-helm-capabilitoes-value branch November 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirbenator nirbenator nirbenator approved these changes

@MickaelAlliel MickaelAlliel Awaiting requested review from MickaelAlliel MickaelAlliel is a code owner

Assignees
No one assigned
Labels
Main Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moran-k @nirbenator