Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86c0fwhr0 - feat: allow not creating rbac at all #334

Merged
merged 1 commit into from
Sep 30, 2024
Merged

CU-86c0fwhr0 - feat: allow not creating rbac at all #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/komodor-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ The command removes all the Kubernetes components associated with the chart and
| createNamespace | bool | `true` | Creates the namespace |
| tags | dict | `{}` | Tags the agent in order to identify it based on `key:value` properties separated by semicolon (`;`) example: `--set tags.env=staging,tags.team=payments` --- Can also be set in the values under `tags` as a dictionary of key:value strings |
| clusterName | string | `nil` | **(*required*)** Name to be displayed in the Komodor web application |
| createRbac | bool | `true` | Creates the necessary RBAC resources for the agent - use with caution! |
| telegrafImageVersion | string | `"1.31.3-alpine-v1"` | Telegraf version to be used |
| telegrafWindowsImageVersion | string | `"1.31.0-v1"` | Telegraf version to be used for windows |
| networkMapperImageVersion | string | `"v1.0.3"` | Network mapper version to be used |
Expand Down
3 changes: 2 additions & 1 deletion charts/komodor-agent/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
{{- if .Values.createRbac -}}
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
Expand Down Expand Up @@ -519,3 +519,4 @@ subjects:
- kind: ServiceAccount
name: {{ include "komodorAgent.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end -}}
2 changes: 2 additions & 0 deletions charts/komodor-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ createNamespace: true
tags: { }
# clusterName -- **(*required*)** Name to be displayed in the Komodor web application
clusterName:
# createRbac -- Creates the necessary RBAC resources for the agent - use with caution!
createRbac: true

# telegrafImageVersion -- (string) Telegraf version to be used
telegrafImageVersion: &telegrafVersion 1.31.3-alpine-v1
Expand Down