chore: address opa violations #332
Merged
+70
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked task to ClickUp! |
Comment on lines
12
to
27
| livenessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| port: http-healthz | ||
| periodSeconds: 60 | ||
| initialDelaySeconds: 15 | ||
| failureThreshold: 10 | ||
| successThreshold: 1 | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /healthz | ||
| port: http-healthz | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 5 | ||
| failureThreshold: 3 | ||
| successThreshold: 1 |
There was a problem hiding this comment.
The node-enricher currently does not expose a /healthz API - It's something we will need to add on the agent
Comment on lines
30
to
34
| securityContext: | ||
| runAsUser: 1000 | ||
| runAsGroup: 3000 | ||
| fsGroup: 2000 | ||
| runAsNonRoot: true |
There was a problem hiding this comment.
This prevents the init container from copying the certificate into /etc
There was a problem hiding this comment.
# kubectl logs -n test-chart helm-test-komodor-agent-88c75854c-4xnxq -c init-cert
~ cp: can't create '/etc/ssl/certs/mitmproxy-ca.crt': Permission denied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cu-86c0ccq6k - OPA Violations - Configure Liveness and Readiness Probes for node-enricher
cu-86c0ccpfj - OPA Violation - Set Resource Quotas for init-daemon and init-cert
cu-86c0ccmyv - OPA Violation - Security Context - komodor-agent
fixes for OPA violations on liveness\readiness probes\ resource qoutas and security context missing