Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(komodor-agent): Support custom labels #320

Merged
merged 3 commits into from
Jun 9, 2024
Merged

feat(komodor-agent): Support custom labels #320

merged 3 commits into from
Jun 9, 2024

Conversation

Moran-k
Copy link
Contributor

@Moran-k Moran-k commented Jun 6, 2024

This PR introduces support for custom labels in the komodor-agent Helm chart. Users can now provide custom labels for various resources, including Deployment, DaemonSet, and DaemonSet-Windows.

Changes:

  • Deployment: Added support for custom labels.
  • DaemonSet: Added support for custom labels.
  • DaemonSet-Windows: Added support for custom labels.

Changelog:

  • Added labels to values.yaml.
  • Created a helper function for label management.
  • Included the custom labels in each resource template.
  • Added tests to verify the correct application of custom labels.

@Moran-k
Copy link
Contributor Author

Moran-k commented Jun 6, 2024

CU-86bykkeu7

@komodor-github-warden
Copy link

Linked task to ClickUp!
Go check it out and add some info: CU-86bykkeu7

nirbenator
nirbenator approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@nirbenator nirbenator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👑

@Moran-k Moran-k merged commit 4448534 into master Jun 9, 2024
2 checks passed
@Moran-k Moran-k deleted the feat/add-labels-to-dep-and-ds branch July 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirbenator nirbenator nirbenator approved these changes

@MickaelAlliel MickaelAlliel Awaiting requested review from MickaelAlliel MickaelAlliel is a code owner

Assignees
No one assigned
Labels
Sprint 31 (2/6 - 15/6) Sprints - Barzelim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moran-k @nirbenator