Avoid redundant document loading

koliyo · Oct 1, 2023 · 36be64a · 36be64a
1 parent 8966d58
commit 36be64a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/Sources/hylo-lsp/DocumentProvider.swift b/Sources/hylo-lsp/DocumentProvider.swift
@@ -137,10 +137,10 @@ actor DocumentProvider {
     return resolveDocumentUrl(uri).absoluteString
   }
 
-  public func preloadDocument(_ textDocument: TextDocumentProtocol) -> DocumentBuildRequest {
-    let uri = DocumentProvider.resolveDocumentUri(textDocument.uri)
-    return preloadDocument(uri)
-  }
+  // public func preloadDocument(_ textDocument: TextDocumentProtocol) -> DocumentBuildRequest {
+  //   let uri = DocumentProvider.resolveDocumentUri(textDocument.uri)
+  //   return preloadDocument(uri)
+  // }
 
   private func preloadDocument(_ uri: DocumentUri) -> DocumentBuildRequest {
     let document = requestDocument(uri)

diff --git a/Sources/hylo-lsp/HyloServer.swift b/Sources/hylo-lsp/HyloServer.swift
@@ -66,11 +66,12 @@ public struct HyloNotificationHandler : NotificationHandler {
 
 
   public func textDocumentDidOpen(_ params: TextDocumentDidOpenParams) async {
-    _ = await state.documentProvider.preloadDocument(params.textDocument)
+    // _ = await state.documentProvider.preloadDocument(params.textDocument)
   }
 
   public func textDocumentDidChange(_ params: TextDocumentDidChangeParams) async {
-    _ = await state.documentProvider.preloadDocument(params.textDocument)
+    // _ = await state.documentProvider.preloadDocument(params.textDocument)
+    // TODO: Handle changes from input (not stored on disk)
   }
 
   public func textDocumentDidClose(_ params: TextDocumentDidCloseParams) async {