-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create projects route and add list each project in a card #41
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
72444db
add global variables and fonts to tailwind + work in projects route
brauliorivas 9751a76
format
brauliorivas 9385c57
Add ts
adriandelgado f590beb
Properly use props
adriandelgado 2fafc2e
Refactor
adriandelgado 71837fd
finish project card according to figma
brauliorivas fa4c4fe
solve merge conflict + include changes
brauliorivas b442f87
format and lint
brauliorivas e991a20
Add TODOs
adriandelgado 9640e41
Remove classes
adriandelgado aa8b690
Handle comments
adriandelgado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
@tailwind base; | ||
@tailwind components; | ||
@tailwind utilities; | ||
|
||
@layer base { | ||
@font-face { | ||
font-family: "Fira Code"; | ||
src: local("fira-code"), url("/fonts/fira-code/FiraCode-VariableFont_wght.ttf"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
<script lang="ts"> | ||
import Tag from "$lib/components/Tag.svelte"; | ||
|
||
type Props = { | ||
term: string; | ||
name: string; | ||
category: string; | ||
description: string; | ||
// authors: string[]; | ||
}; | ||
|
||
let { term, name, category, description /* , authors */ }: Props = $props(); | ||
</script> | ||
|
||
<!-- TODO: Use semantic CSS https://www.magentaa11y.com/checklist-web/link/#complex-examples --> | ||
<div class="m-4 max-w-72 rounded-2xl bg-neutral-800 px-6 py-4"> | ||
<div class="mb-4"> | ||
<span class="font-fira font-medium text-lime-500">{term}</span> | ||
<h2 class="font-fira text-xl font-medium text-white">{name}</h2> | ||
</div> | ||
<Tag {category} /> | ||
<p class="my-4">{description}</p> | ||
<div class="flex w-full flex-row justify-between"> | ||
<div class="flex flex-row items-center justify-center"> | ||
<!-- TODO: Implement author's avatars --> | ||
<!-- {#each authors as author} | ||
<img src="https://via.placeholder.com/150" alt={author} class="h-4 w-4 rounded-full" /> | ||
{/each} --> | ||
</div> | ||
<button class="rounded-full bg-lime-500 px-2 font-fira text-sm font-bold text-black"> | ||
Ver más | ||
</button> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<script lang="ts"> | ||
type Props = { | ||
category: string; | ||
}; | ||
|
||
let { category }: Props = $props(); | ||
</script> | ||
|
||
<span | ||
class="rounded-full border border-lime-500 bg-neutral-800 px-6 font-fira font-bold text-white" | ||
> | ||
{category} | ||
</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"projects": [ | ||
{ | ||
"term": "2024-1s", | ||
"name": "Polipromedios", | ||
"category": "web", | ||
"description": "Descripción de un proyecto super genial, muy, muy, muy pero muy genial.", | ||
"authors": ["Person 1", "Person 2"] | ||
}, | ||
{ | ||
"term": "2024-1s", | ||
"name": "Polipromedios", | ||
"category": "web", | ||
"description": "Descripción de un proyecto super genial, muy, muy, muy pero muy genial.", | ||
"authors": ["Person 1", "Person 2"] | ||
}, | ||
{ | ||
"term": "2024-1s", | ||
"name": "Polipromedios", | ||
"category": "web", | ||
"description": "Descripción de un proyecto super genial, muy, muy, muy pero muy genial.", | ||
"authors": ["Person 1", "Person 2"] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<script lang="ts"> | ||
import CommonCard from "$lib/components/CommonCard.svelte"; | ||
|
||
let { data } = $props(); | ||
adriandelgado marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</script> | ||
|
||
<p class="font-medium">{data.description}</p> | ||
<div class="mt-8 flex flex-col items-center sm:flex sm:flex-row sm:flex-wrap"> | ||
{#each data.projects as project} | ||
<CommonCard | ||
term={project.term} | ||
name={project.name} | ||
category={project.category} | ||
description={project.description} | ||
/> | ||
{/each} | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import type { PageLoad } from "./$types"; | ||
import { projects } from "$lib/data/projects.json"; | ||
|
||
export const load = (async () => { | ||
return { | ||
title: "Proyectos", | ||
// TODO: change this to a real description | ||
description: "Aquí ponemos los proyectos que nos enorgullecen... y lo que hay ¯\\_(ツ)_/¯", | ||
// TODO: fetch from API | ||
projects, | ||
}; | ||
}) satisfies PageLoad; |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mismo asunto que con el componente MoreButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta Tag se usa en otros lados, no solo en la ProjectCard.