-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: #48: vt and magistrate support #49
Draft
nmm0
wants to merge
17
commits into
main
Choose a base branch
from
48-vt-and-magistrate-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects across function invocations
Restructured backends to extend a top-level virtual object (more backends to update) New VTProxy registration which just checkpoints status info about that proxy, but also registers to the VTContext for special handling of the actual data VeloC doesn't appear to have a way to checkpoint an object as just a single node (e.g. each checkpoint of a proxy element is a node's iteration's element data, not the iteration's element data), so recovering to different node positions is currently not possible Working on that before I start the steps for handling recovery of the VT data in the VTContext. I may just use update the file backend to the new virtual hierarchy and use that for more configurability for now. Checkpoints of status info seem very large right now, some 66M for each node with only one collection and one objgroup being checkpointed. I have not yet investigated that Another todo, attaching listeners to collection element migration events, to send the updated status info alongside. Not an immediate concern.
nmm0
commented
Jun 8, 2023
option(KR_ENABLE_STDFILE "use StdFile backend for automatic checkpointing" OFF) | ||
|
||
option(KR_ENABLE_MAGISTRATE "use Magistrate for serializing and deserializing" OFF) | ||
option(KR_ENABLE_RESILIENT_EXEC "enable resilient execution spaces" OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah just noticed this is wrong, see KR_ENABLE_EXEC_SPACES
below. I think I messed this up in the rebase somewhere
(cherry picked from commit 3e08aa6) Conflicts: CMakeLists.txt src/resilience/AutomaticCheckpoint.hpp src/resilience/CMakeLists.txt src/resilience/backend/AutomaticBase.hpp src/resilience/backend/stdfile/StdFileBackend.cpp src/resilience/backend/stdfile/StdFileBackend.hpp src/resilience/backend/veloc/VelocBackend.cpp src/resilience/backend/veloc/VelocBackend.hpp src/resilience/context/ContextBase.hpp src/resilience/context/VTContext.hpp src/resilience/registration/Registration.hpp src/resilience/registration/ViewHolder.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48