Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing checks #196

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

yasahi-hpc
Copy link
Collaborator

This PR aims at adding missing checks.

  • Add extents consistency check for all-extents. Previously, we checked only for the transform axis of R2C and C2R transforms.
  • Disallow to use inplace Plan on out-of-place Views (plan is not identical)
  • Add throw tests for these cases

@yasahi-hpc yasahi-hpc self-assigned this Nov 5, 2024
@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Nov 5, 2024
@tpadioleau tpadioleau self-requested a review November 6, 2024 11:51
tpadioleau
tpadioleau previously approved these changes Nov 26, 2024
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me, still working fine on GPU ?

fft/unit_test/Test_Transform.cpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

ok for me, still working fine on GPU ?

Thanks!
I will fix accordingly.
It runs correctly on GPUs. The current failure stems from the time-out issue

@tpadioleau
Copy link
Member

It runs correctly on GPUs. The current failure stems from the time-out issue

Strange, are you sure something is not broken ? I would expect that within a day a single GPU would be available.

@yasahi-hpc
Copy link
Collaborator Author

It runs correctly on GPUs. The current failure stems from the time-out issue

Strange, are you sure something is not broken ? I would expect that within a day a single GPU would be available.

Let me run CI again.

@tpadioleau
Copy link
Member

I ran squeue on the supercomputer and it returns an empty list of jobs.

@yasahi-hpc
Copy link
Collaborator Author

I ran squeue on the supercomputer and it returns an empty list of jobs.

That is true. Let me check

@yasahi-hpc
Copy link
Collaborator Author

I ran squeue on the supercomputer and it returns an empty list of jobs.

That is true. Let me check

I found that the runner is offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants