Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ci #13

Merged
merged 18 commits into from
Feb 8, 2024
Merged

Extend ci #13

merged 18 commits into from
Feb 8, 2024

Conversation

kod-kristoff
Copy link
Owner

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request significantly extends the continuous integration (CI) capabilities of the project by introducing a comprehensive suite of GitHub Actions workflows. It covers various aspects such as code formatting, linting with clippy, documentation checks, feature flag combinations, minimum supported Rust version (MSRV) verification, no-std compatibility, safety checks including undefined behavior and memory leaks, scheduled rolling updates, and extensive testing across different operating systems and Rust toolchain versions. Additionally, it integrates codecov for coverage reporting and configures dependabot for dependency management.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that all newly introduced workflows are thoroughly tested to prevent any disruptions in the CI pipeline.
  • Consider documenting the rationale behind each workflow in the project's main documentation to help new contributors understand the CI/CD process.
  • Review the use of external actions, especially those pinned to 'master' or 'nightly' versions, to mitigate potential instability risks.
  • Regularly review and update the CI configurations to adapt to new GitHub Actions features or changes in the project's requirements.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 795 lines in your changes are missing coverage. Please review.

Comparison is base (130f144) 2.5% compared to head (58198b3) 37.4%.
Report is 56 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
...infrastructure/repository/in_memory/mem_persons.rs 100.0% <100.0%> (ø)
tui/src/mode.rs 100.0% <100.0%> (ø)
ancestors-core/src/domain/types/name_part_type.rs 0.0% <0.0%> (ø)
ancestors-core/src/domain/conclusion/name_form.rs 77.7% <77.7%> (ø)
ancestors-core/src/shared_kernel/person_id.rs 88.8% <88.8%> (ø)
ancestors-core/src/domain/conclusion/name.rs 82.5% <82.5%> (ø)
tui/src/app/components/shared/container.rs 0.0% <0.0%> (ø)
tui/src/app/components/home.rs 0.0% <0.0%> (ø)
tui/src/action.rs 80.7% <80.7%> (ø)
tui/src/event.rs 0.0% <0.0%> (ø)
... and 19 more

... and 1 file with indirect coverage changes

@kod-kristoff kod-kristoff merged commit be9cfb5 into main Feb 8, 2024
17 checks passed
@kod-kristoff kod-kristoff deleted the extend-ci branch February 8, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant