Prevent certain configuration settings from unexpectedly reverting to defaults #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add workaround for constance to not reset values to default when unable to connect to a database object.
noliveleger
requested changes
Jun 14, 2022
kobo/settings/base.py
Outdated
| @@ -844,6 +845,11 @@ def __init__(self, *args, **kwargs): | |||
| 'socket_timeout': env.int('REDIS_SESSION_SOCKET_TIMEOUT', 1), | |||
| } | |||
|
|
|||
| CACHES = { | |||
| # Set CACHE_URL to override | |||
| 'default': env.cache(default=env.str("REDIS_SESSION_URL", default='redis://redis_cache:6380/2')), | |||
There was a problem hiding this comment.
I would rather use another variable name REDIS_CONSTANCE_BACKEND_URL (in single-quote :P). I know it's another one, but I would leave the session database alone and use a different index.
What do you think?
There was a problem hiding this comment.
Seems reasonable. That means adding to kobo-install right? I suppose kobo-install doesn't need to ask anything extra, but needs to set this new env var.
For future local dev environments, it could use the passwordless default redis_cache with a different index.
There was a problem hiding this comment.
Exactly kobotoolbox/kobo-install#193
|
LGTM, tests are passing locally. |
p2edwards
added a commit
to jnm/kobo-no-docker
that referenced
this pull request
Jun 29, 2022
jnm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work around django-constance issue where values are undesirably reset to their default.
Add redis cache for constance database backend.
Introduces a new environment variable
CACHE_URLto define the default Django cache. This is only used for constance right now, but could be used elsewhere.Internal notes
This requires updating kobo-install. Do not release this change until kobo-install is updated to support CACHE_URL with the existing redis instance.