Kraken: add support for OHLC Streaming #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you fix the conflicts, I will merge this. |
feat: add support for OHLC streaming on kraken.com
|
Rebased and fixed conflicts. |
|
Hello @rvullriede After merging, |
|
@timmolter, I've pushed the missing class, I got lost during cleaning up my git history. sorry for that. |
|
ok, thanks. Can you make a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for OHLC Streaming for Kraken. It requires a (backward-compatible) change to NettyStreamingService in order to allow streaming of OHLC for multiple intervals for the same currrency pair.
Without this change the channelId won't be unique and interfere with each other.