Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/polo okex candle data catch up #4723

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Feature/polo okex candle data catch up #4723

wants to merge 9 commits into from

Conversation

maghteriton
Copy link
Contributor

Fixed the periodInSecs calculation

maghteriton and others added 9 commits March 13, 2022 19:49
@maghteriton
- polo okex candle stick
3233741
@maghteriton
- polo okex candle stick 2
8b4d657
@aligokalppeker
Merge branch 'knowm:develop' into feature/polo_okex_candle_data
1c74880
@aligokalppeker
Review comments has been performed.
d866fa8 
More generalized candle stick parameter input is provided.
@maghteriton
Merge branch 'develop' of https://github.com/knowm/XChange into featu…
3796771 
…re/polo_okex_candle_data_catch_up

� Conflicts:
�	xchange-core/src/main/java/org/knowm/xchange/service/marketdata/MarketDataService.java
�	xchange-okex/src/main/java/org/knowm/xchange/okex/service/OkexCandleStickPeriodType.java
�	xchange-okex/src/main/java/org/knowm/xchange/okex/v5/OkexAdapters.java
�	xchange-okex/src/main/java/org/knowm/xchange/okex/v5/service/OkexMarketDataService.java
@maghteriton
polo okex candle data branch updated from upstream
8edcfcc
@maghteriton
commit fix
9152e34
@maghteriton
removed unused imports
8f1275e
@maghteriton
fixed imports
620140d
@aligokalppeker
Copy link
Contributor

Hi @earce,

Regardless of this PR, the build pipeline seems to be crashing for Kucoin. Is there any option, we can merge this PR?

@bigscoop
Copy link
Contributor

bigscoop commented Jun 7, 2023

looks like the version of org.knowm.xchange:xchange-stream-kucoin is wrong

@aligokalppeker
Copy link
Contributor

It may be but we did not change any version, it has been done before. One another issue may be the compilation issue.

@bigscoop
Copy link
Contributor

bigscoop commented Jun 7, 2023

yes, it was merged in develop by mistake, so you can fix it in your branch as well.
just replace version of parent pom in xchange-stream-kucoin/pom.xml so that it looks like that

    <parent>
        <groupId>org.knowm.xchange</groupId>
        <artifactId>xchange-parent</artifactId>
        <version>5.1.1-SNAPSHOT</version>
    </parent>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maghteriton @aligokalppeker @bigscoop