[jsk_fetch_startup] Publish diagnostics for important topics and nodes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2022
Merged
|
Could you review this? |
708yamaguchi
force-pushed
the
sanity-diagnostics-fetch15
branch
from
f37e175 to
94b9250
Compare
|
Checked with @tkmtnt7000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want fetch to indicate that topic has not come or node does not exist.
For example, I want to check existence of
/audioor/insta360, whose publisher does not publish/diagnostics.What I did in this PR is as follows:
Check if the ROS topics using the fetch device are published. #104
This PR depends on knorth55/jsk_common#4
PR to jsk-ros-pkg
jsk-ros-pkg#1481