Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pr1040] Enable dynamic reconfigure for audible warning to stop it. #22

Merged
merged 25 commits into from
Jul 7, 2022
Merged

[pr1040] Enable dynamic reconfigure for audible warning to stop it. #22

merged 25 commits into from
Jul 7, 2022

Conversation

iory
Copy link
Collaborator

@iory iory commented Jul 6, 2022

What is this?

This change allows audible warnings to be turned on and off by dynamic reconfigure.
This PR's upstream is jsk-ros-pkg#1607

cc @708yamaguchi

iory added 25 commits July 6, 2022 20:49
@iory
[audible_warning] Add diagnostics_level_to_str
bc313e0
@iory
[audible_warning] Add dynamic reconfigure parameters
052c8d0
@iory
[audible_warning/sample] Fixed audible_warning node name
c044fc5
@iory
[audible_warning] Use dynamic reconfigure params
30820b2
@iory
[audible_warning] Add inflection_utils for camel_to_snake case
c4c19f1
@iory
[audible_warning] Add ignore after runstop time
3baeafd
@iory
[audible_warning] Ignore if self.run_stop_(disabled|enabled)_time is …
8e4feef 
…None
@iory
[audible_warning] Add docs for dynamic reconfigure's parameters
60f4f58
@iory
[audible_warning] Move audible_warning.py to node_scripts.
22fe196
@iory
[audible_warning] Fixed lint test target path
23f29e2
@iory
[audible_warning] Fixed lint
9a48866
@iory
[audible_warning] Convert multiple space to one
cdf9966
@iory
[audible_warning] Convert colon symbol to english text
881b66f
@iory
[audible_warning] Add publishing text
474d5cf
@iory
[audible_warning] Add AudibleWarningClient for reconfigure
1d596ee
@iory
[audible_warning] Make speak_when_runstopped dynamic params
d657110
@iory
[audible_warning] Don't add heap at first
a2b86fa
@iory
[audible_warning] Deserialize image
6d17411
@iory
[audible_warning] Fixed typo by adding ()
741954b
@iory
[audible_warning] Add loginfo to display runstop state
269d3e2
@iory
[audible_warning] Add pseudo runstop publisher
1d3cf65
@iory
[audible_warning] Add prefix + error name to original text
e23b15f
@iory
[jsk_tools/audible_warning] Modified default speak rate to speed up.
6ad0bb7
@iory
[jsk_tools/audible_warning] Add space to published original text.
a1d225b
@iory
[jsk_tools/audible_warning] Set wait_speak_duration_time to wait acti…
558cd86 
…on server result.
@iory iory mentioned this pull request Jul 6, 2022
Merged
708yamaguchi
708yamaguchi approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is next part of #7

@708yamaguchi 708yamaguchi merged commit b90ac37 into knorth55:pr1040 Jul 7, 2022
@iory iory deleted the pr1040-audible-warning branch July 8, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iory @708yamaguchi