Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest dependencies #1485

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Oct 24, 2024

Cron -knative-prow-robot

/cc knative-extensions/eventing-rabbitmq-approvers
/assign knative-extensions/eventing-rabbitmq-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team October 24, 2024 14:03
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.04%. Comparing base (ec11c15) to head (7bc251a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1485   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files          60       60           
  Lines        4341     4341           
=======================================
  Hits         2737     2737           
  Misses       1489     1489           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2024
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 6 times, most recently from 55d9b26 to 8297c50 Compare November 1, 2024 01:55
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2024
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 8 times, most recently from 380d9ea to 504ba81 Compare November 8, 2024 01:54
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 2 times, most recently from e8beb03 to 91922cb Compare November 11, 2024 13:31
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2024
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 4 times, most recently from 4c8224f to 7fc121e Compare November 14, 2024 13:35
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 8 times, most recently from 0157ec3 to a5c15e6 Compare November 21, 2024 13:36
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 3 times, most recently from 4e6d892 to bfe15b1 Compare November 25, 2024 13:36
bumping golang.org/x/crypto adef4cc...6018723:
  > 6018723 go.mod: update golang.org/x dependencies
  > 71ed71b README: don't recommend go get
  > 750a45f sha3: add MarshalBinary, AppendBinary, and UnmarshalBinary
  > 36b1725 sha3: avoid trailing permutation
  > 80ea76e sha3: fix padding for long cSHAKE parameters
  > c17aa50 sha3: avoid buffer copy
  > 7cfb916 ssh: return unexpected msg error when server fails keyboard-interactive auth early
  > b61b08d chacha20: extend ppc64le support to ppc64
  > 6c21748 internal/poly1305: extend ppc64le support to ppc64
bumping golang.org/x/tools 2ab3b51...4d2b19f:
  > 4d2b19f go.mod: update golang.org/x dependencies
  > 6368677 gopls/internal/golang: strength reduce ComputeImportFixEdits
  > 777f155 gopls/internal/golang: show package attributes on hover
  > 8a0e08f gopls/doc: add missing doc link
  > 61415be gopls/internal/cache: guard against malformed paths in port.matches
  > 9a89d3a internal/analysisinternal: avoid sub-token spans in TypeErrorEndPos
  > 1115af6 internal/expect: support named arguments f(a, b, c=d, e="f")
  > 0b9e499 go/{expect,packages/packagestest}: mention the tag+delete proposal
  > efcd2bd internal/packagestest: fork go/packages/packagestest
  > 0e9ed3d go/packages: do not mutate Config
  > ca2b41b x/tools: use internal/expect instead of go/expect
  > b22f1ad internal/expect: fork go/expect
  > f1ae722 gopls/internal/semtok: change types.Named to types.Basic for iota, true, and false
  > dba5486 gopls: update x/telemetry to pick up fix for countertest.ReadCounter
  > 9d40727 gopls/internal/server: don't interact with os.UserConfigDir from tests
  > 59933b6 go/packages: create fewer goroutines
  > f1f7c26 gopls/internal/cache: ensure GO111MODULE is unset in GOPATH tests
  > 4f98d3f gopls/internal/golang: run testcases as subtests
  > 6d27bba gopls/internal/golang: add testcase handling for func with error returns
  > e5417d7 gopls/internal/cache: log go env in TestZeroConfigAlgorithm
  > 691997a gopls/internal/golang: consolidate imports from both file in qualifier
  > 0c792f1 gopls/internal/golang: support generating test for functions
  > 27e1a3a go/packages: ensure TypesInfo is set when NeedTypesInfo is enabled
  > 817c7bc gopls/internal/test/integration/workspace: fix TestStdWorkspace
  > e36459f gopls/internal/golang: generate test name for selected function/method
  > 2998e9a go/analysis/passes/lostcancel: add WithCancelCause et al
  > f0379e0 go/packages: add BenchmarkNetHTTP
  > ad28b93 go/packages: minor cleanups to loader.parseFiles
  > cceaf96 internal/imports: carve out a Source interface for index integration
  > f4878ba gopls/internal/golang: use correct imports in HTML pkg doc links
  > 109c5fc gopls/internal/test: fix path to local go in integration tests
  > 99e8fee x/tools: fset.File(file.Pos()) -> fset.File(file.FileStart)
  > 5cd08e2 go/gcexportdata: document 2 releases + tip policy
  > ce03cd6 internal/modindex: parse changed time in local time zone
  > 386503d gopls/internal/golang: add source code action for add test
  > 9d6e1a6 Revert "gopls/internal/analysis: disable ssa/ir analyzers on range-over-func"
  > f153a42 gopls: update honnef.co/go/tools (staticcheck) to v0.5.1
  > 59f79bc go/ssa: speed up TestTypeparamTest by loading tests once
  > 70e82e0 go/analysis/passes/asmdecl: Correct identify writeResult instructions
  > cbd92b1 gopls/internal: stubcalledfunction: improve logic of selecting insert position
  > 45a28e1 all: fix x/tools tests that fail with a go1.23.1 go.work file
  > b0f44d5 copyright: limit copyright checking to .go files
  > 73d6794 gopls/internal/template: fix completion token boundary conditions
  > 91421d7 gopls/internal/cache: share type checking with analysis
  > 36684df go/analysis/passes/unusedwrite: silence if unsafe is imported
  > 17213ba gopls/internal/cache/parsego: support lazy object resolution for Files
  > 7d1d070 go/ssa/interp: disable interp tests on wasm
  > ae56d93 internal/modindex: implement Lookups in the index
  > 044b16f internal/gcimporter: extend markBlack workaround go1.22
  > dabba6a internal/modindex: new API for incremental update
  > 7d196fc go/ssa/interp: fix failing recover2.go test
  > f861377 go/ssa/interp: redirect interpreter std{out,err} to testing.T.Log
  > 9f3c646 gopls/internal/cache: memoize cache keys
  > 1f162c6 gopls/internal/cache: async pull diagnostics and joined analysis
  > dbb8252 gopls/release: remove unused(?) script
  > 6176384 go/types/objectpath: break cycles through interface methods
  > 9e6388a internal/gcimporter: work around go/types data race in 1.23.
  > c457787 gopls/internal/cache: avoid reporting bugs when go/packages has errors
  > 401eca0 gopls/internal/settings: remove "allowImplicitNetworkAccess"
  > 6618569 gopls/internal/cache: refine a bug report related to package metadata
  > 6381f0b gopls/internal/cache: refine bug reports
  > 63e4449 gopls/internal/telemetry/cmd/stacks: print double-claimed stacks
  > f003ff6 gopls/internal/test/marker: rename s/suggestedfix/quickfix/
  > 8128bcf gopls/internal/cache: add tolerance for builtin test variants
  > a199121 gopls: allow for asynchronous request handling
  > 8ecf757 internal/gcimporter: remove test of unsupported "goroot" iimport
  > 7310c72 importgraph: correct typo in graph_test.go
  > ce4cb55 internal/modindex: fix two bugs
  > b3482cc internal/modindex/cmd: Command for maintaining module cache indexes
  > 454be60 x/tools: be defensive after types.Info.Types[expr] lookups
  > dec6bf1 internal/modindex: update module cache index
  > 6c6def2 gopls/internal/telemetry/cmd/stacks: fix bad tmpreaper interaction
  > 1a5fe83 gopls: remove cruft
  > 244a31e gopls/internal: CodeAction:  quickfix to generate missing method
  > 87d6131 internal/typeparams: support parameterized aliases in Free
  > aa87dcf go/analysis/passes: execute gofmt
  > feffeaa go/packages: report an error from Load when GOROOT is misconfigured
  > 50179f2 Revert "internal/aliases: add a function to conditionally enable aliases"
  > 4f6e118 all: set gotypesalias=1 when using >=1.23 toolchain
  > 915132c internal/typesinternal: add NamedOrAlias type
  > bd86f8c gopls/internal/cache/analysis: lazily resolve the import map
  > a4e0a9e cmd/bundle: enable materialized aliases
  > db26c69 cmd/stringer: fix test on android
  > f08b5c1 gopls/internal/test/integration/bench: add a pull diagnostics benchmark
  > bbb979f go/callgraph/vta: use node IDs for type flow graph
  > cf8979b gopls/doc/features: add index of supported Code Actions
  > 8621919 go/ssa/ssautil: disable fmt imports on wasm tests
  > f439874 internal/modindex: add symbol information
  > f21a1dc gopls: add initial support for pull diagnostics
  > c19060b gopls/internal/cache: use packageHandles to hold an active package cache
  > a30b207 internal/versions: remove InitFileVersions
  > de11c55 gopls/doc/codelenses: fix link typo
  > 0b989c8 internal/versions: update test expectations
  > 89a5311 go/analysis/passes/asmdecl: allow syscall write registers implicitly
  > f8f3c13 internal/aliases: add a function to conditionally enable aliases
bumping golang.org/x/sync 411f99e...151027e:
  > 151027e README: don't recommend go get
bumping golang.org/x/oauth2 6d8340f...3e64809:
  > 3e64809 x/oauth2: add Token.ExpiresIn
  > 16a9973 jwt: rename example to avoid vet error
  > b52af7d endpoints: add GitLab DeviceAuthURL
bumping knative.dev/hack 05b2fb3...b799531:
  > b799531 Update community files (# 403)
  > ef6e7e9 Export KO_FLAGS for consuming scripts (# 401)
  > 2191456 Update community files (# 400)
bumping google.golang.org/genproto/googleapis/rpc ddb44da...8af14fe:
  > 8af14fe chore(all): update all (# 1159)
  > 7e3bb23 chore(all): auto-regenerate .pb.go files (# 1158)
  > f6391c0 chore(all): update all (# 1156)
  > 3fd189d chore(googleapis): update cloud/gkeconnect/gateway/v1beta1/alias.go (# 1157)
  > 4ba0660 chore: update datastore and bigtable (# 1155)
  > fc7c04a feat: move SoT for datastore proto definitions (# 1154)
  > 278611b chore(all): update all (# 1153)
bumping golang.org/x/mod 46a3137...dec0365:
  > dec0365 sumdb: make data tiles by Server compatible with sum.golang.org
  > c8a7319 x/mod: fix handling of vendored packages with '/vendor' in non-top-level paths
  > 9cd0e4c x/mod: remove vendor/modules.txt from module download
bumping golang.org/x/text 3043346...efd25da:
  > efd25da go.mod: update golang.org/x dependencies
  > 8a0e65e README: don't recommend go get
  > fefda1a internal/texttest: remove Run and Bench helpers
  > a457f47 all: normalize subtest names to NFC
bumping knative.dev/reconciler-test 09111f0...0619dc3:
  > 0619dc3 Update community files (# 773)
  > aae114c upgrade to latest dependencies (# 771)
  > 9d5e1c0 Update community files (# 770)
  > 22c241b upgrade to latest dependencies (# 769)
  > 3e8ae56 Update community files (# 768)
bumping google.golang.org/genproto/googleapis/api ddb44da...8af14fe:
  > 8af14fe chore(all): update all (# 1159)
  > 7e3bb23 chore(all): auto-regenerate .pb.go files (# 1158)
  > f6391c0 chore(all): update all (# 1156)
  > 3fd189d chore(googleapis): update cloud/gkeconnect/gateway/v1beta1/alias.go (# 1157)
  > 4ba0660 chore: update datastore and bigtable (# 1155)
  > fc7c04a feat: move SoT for datastore proto definitions (# 1154)
  > 278611b chore(all): update all (# 1153)
bumping google.golang.org/protobuf 158d2b3...c72053a:
  > c72053a all: release v1.35.2
  > b985635 internal/impl: fix TestMarshalMessageSetLazyRace (was a no-op!)
  > 76135f9 proto: switch messageset_test to use makeMessages() injection point
  > 29947bb internal/testprotos/test: add nested message field with [lazy=true]
  > 5c14d72 encoding/prototext: use testmessages_test.go approach, too
  > 496557b proto: refactor equal_test from explicit table to use makeMessages()
  > 0517e5a testing/protocmp: document behavior when combining Ignore and Sort
  > d14ebce all: implement strip_enum_prefix editions feature
  > fb995f1 encoding/protojson: allow missing value for Any of type Empty
  > d340238 all: start v1.35.1-devel
bumping knative.dev/pkg 9b9d535...a7fd9b1:
  > a7fd9b1 Bump google.golang.org/protobuf from 1.35.1 to 1.35.2 (# 3117)
  > 215048a Bump golang.org/x/tools from 0.26.0 to 0.27.0 (# 3114)
  > 47a6f9f Bump google.golang.org/grpc from 1.67.1 to 1.68.0 (# 3116)
  > 7b333a0 Bump golang.org/x/net from 0.30.0 to 0.31.0 (# 3113)
  > 0a99635 Update community files (# 3112)
  > 25f6002 upgrade to latest dependencies (# 3111)
  > 6af2bf9 upgrade to latest dependencies (# 3110)
  > 76cfa12 Fix `WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP` env-var (# 3107)
  > 6d10851 Add `WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP` env-var (# 3103)
  > 6eb75e8 Update community files (# 3105)
bumping google.golang.org/grpc 3f95b38...acba4d3:
  > acba4d3 Change version to 1.68.0 (# 7743)
  > 5363dca credentials: Apply defaults to TLS configs provided through GetConfigForClient (# 7754) (# 7813)
  > 056dc64 status: Fix status incompatibility introduced by # 6919 and move non-regeneratable proto code into /testdata (# 7724) (# 7793)
  > b79fb61 mem: use slice capacity instead of length, to determine whether to pool buffers or directly allocate them (# 7702) (# 7792)
  > 54841ef  stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file (# 7740)
  > ad81c20 pickfirstleaf: minor simplification to reconcileSubConnsLocked method (# 7731)
  > b850ea5 transport : wait for goroutines to exit before transport closes (# 7666)
  > 00b9e14 pickfirst: New pick first policy for dualstack (# 7498)
  > 18a4eac testutils: add couple of log statements to the restartable listener type (# 7716)
  > fdc2ec2 xdsclient: deflake TestADS_ResourcesAreRequestedAfterStreamRestart (# 7720)
  > 4115c21 xds: return all ServerConfig dial options together (# 7718)
  > b8ee37d pickfirst: Move var for mocking the shuffle func from internal/internal to pickfirst/internal (# 7698)
  > d9d8f34 revert xds: return all ServerConfig dial options together (# 7712)
  > 5f178a8 xdsclient: fix test build breakage (# 7710)
  > f17ea7d xds: return all ServerConfig dial options together (# 7680)
  > bdd444d xds: address merge conflict gotcha and missed review comment from previous PRs (# 7705)
  > d365be6 transport: prevent deadlock in transport Close when GoAway write hangs (# 7662)
  > 6c6c9b6 xdsclient: e2e style tests for ads stream restart (5/N) (# 7696)
  > 5e6f4b9 xds: misc test cleanup (4/N) (# 7695)
  > 3adcd41 xdsclient: make load reporting tests e2e style (3/N) (# 7694)
  > 98d1550 xdsclient: switch more transport tests to e2e style (2/N) (# 7693)
  > 9afb232 xdsclient: invoke watch callback when new update matches cached one, but previous update was NACKed (1/N) (# 7692)
  > ab5af45 Revert "protoc-gen-go-grpc: remove `use_generic_streams_experimental`  flag (defaults to true) (# 7654) (# 7703)
  > e8a70c6 vet: add check to ensure terminating newline (# 7645)
  > 5fd9853 examples: improve package comments (# 7658)
  > 859602c vet : add check for tabs in text files (# 7678)
  > 67e47fc xds: Fix flaky test TestUnmarshalListener_WithUpdateValidatorFunc (# 7675)
  > ca4865d balancer: automatically stop producers on subchannel state changes (# 7663)
  > 941102b xds/server: Fix xDS Server leak (# 7664)
  > 7aee163 xds: add xDS transport custom Dialer support (# 7586)
  > 9affdbb internal/credentials/xds: add unit tests for `HandshakeInfo.Equal` (# 7638)
  > 3196f7a protoc-gen-go-grpc: remove `use_generic_streams_experimental` flag (defaults to true) (# 7654)
  > 218811e balancer/rls: Add picker and cache unit tests for RLS Metrics (# 7614)
  > a9ff62d clusterresolver/e2e_test: Avoid making real DNS requests in TestAggregateCluster_BadEDS_BadDNS (# 7669)
  > e7a8097 cleanup: replace grpc.Dial with grpc.NewClient in tests (# 7640)
  > bcf9171 transport: Fix reporting of bytes read while reading headers (# 7660)
  > 8ea3460 balancer: fix logic to prevent producer streams before READY is reported (# 7651)
  > 6c48e47 replace tab with spaces in text files (# 7650)
  > 1418e5e clusterimpl: use gsb.UpdateClientConnState instead of switchTo, on receipt of config update (# 7567)
  > ac41314 .*: Add missing a newline at the end (# 7644)
  > 11c44fb vet: add comment explaining reason for revive lineter disabled rules (# 7634)
  > 3b626a7 *: fix more typos (# 7619)
  > 04e78b0 .*: fix lint issues of not having comments for exported funcs and vars along with any remaining issues and enable remaining disabled rules (# 7575)
  > 31ffeee Deps: Bump Go version in Dockerfiles and test/kokoro/xds.sh (# 7629)
  > 393fbc3 Update dependencies after 1.67 branch cut (# 7624)
  > cf5d541 stubserver: support xds-enabled grpc server (# 7613)
  > b6fde8c vet: add check for trailing spaces (# 7576)
  > 7fb7ac7 mem: replace flate.Reader reference (# 7595)
  > 8f920c6 Change version to 1.68.0-dev (# 7601)
bumping golang.org/x/sys 23b0dab...e0753d4:
  > e0753d4 Revert "windows/mkwinsyscall: use syscall.SyscallN instead of syscall.Syscall{6,9,12,15}"
  > c29efe3 windows: add iphlpapi functions for change notifications
  > 8f2aa9f cpu: conditionally re-enable AVX512 support on darwin/amd64
  > 054f1fc README: don't recommend go get
  > ca04041 unix: extend z/OS support
  > 18e038c unix: move NETLINK_* consts to own section
  > d045236 windows: implement Ftruncate using a single syscall on Windows
  > cff53d5 unix: gofmt after CL 610296
  > 123459f unix: update z/OS implementation of fcntl and mmap
  > df4a4da unix/linux: adjust Dockerfile ENV key value format
  > 696d342 unix: gofmt after CL 621375
  > 60d7877 unix: add PTP_PF_* constants on Linux
  > 256d1df unix: add PTP IOCTLs on Linux
  > adbb8bb windows/mkwinsyscall: use syscall.SyscallN instead of syscall.Syscall{6,9,12,15}
  > a57fdb8 unix: add IoctlGetHwTstamp/IoctlGetHwTstamp on Linux
  > 3932916 unix: switch to Ubuntu 24.10 in Dockerfile
  > 2dfefb6 all: execute gofmt
  > e5eee7e unix: add IoctlGetEthtoolTsInfo on Linux
  > fe162ba unix: add ClockSettime on Linux
  > 7143f4a windows: manually initialize NewNTUnicodeString
bumping knative.dev/eventing 291c0a8...65da6fc:
  > 65da6fc Update integrationsink crd  (# 8347)
  > 01c8068 JobSink: Inject a `KNATIVE_EXECUTION_MODE` environment variable with value `batch` (# 8346)
  > 366ff26 IntegrationSink: rek-test templating support for bool annotations (# 8342)
  > 7176ce6 Add IntegrationSink CRD  (# 8304)
  > 5ad7dab feat: add RequestReply types and CRD (# 8337)
  > 7f313d7 fix: rename `job-sink` to `job_sink` (# 8335)
  > 4f6535a chore: correct comments (# 8336)
  > ebe99e6 Introducing common integration helper and change package name (# 8327)
  > 201e096 [main] Format Go code (# 8334)
  > 6f5edf5 [main] Upgrade to latest dependencies (# 8328)
  > f21370a Integration Api moved to versioned common (# 8325)
  > 63d4da5 Update Integration API and use custom tags on structs for better readability (# 8321)
  > 7abb04d JobSink: Delete secrets associated with jobs when jobs are deleted (# 8331)
  > 8fed0be Allow configuring (opt-in) IMC async handler  (# 8311)
  > bc6e878 fix: remove duplicated observedGeneration from jobsinks.sinks.knative.dev (# 8326)
  > 6b4ff7f [main] Upgrade to latest dependencies (# 8324)
  > cd31c1b [main] Upgrade to latest dependencies (# 8322)
  > 9d67389 [chore] Do not generate SSL env vars for each struct entry, just once per containersource/image (# 8315)
  > 35d8c63 [chore] Use a generic access/secret key in the secret for AWS connections (# 8312)
  > f53d038 [main] Update community files (# 8307)
  > df34028 Add missing copyright boilerplate (# 8305)
  > 3f2b75b Use GetServiceHostname when passing URL to JobSink (# 8303)
  > fa6b4c5 Add jobsinks-addressable-resolver cluster role (# 8298)
  > b4b609a Add observedGeneration in JobSink OpenAPI schema (# 8297)
  > 2e4d353 Allow imc-controller to list JobSinks (# 8294)
  > 7bca815 IntegrationSource CRD (# 8238)
  > c859efd [main] Format Go code (# 8289)
  > 7c97e6f Schduler: MAXFILLUP strategy will spread vreplicas across multiple pods (# 8263)
  > ef6b31a fix: et autocreate makes eventtype id required (# 8288)
  > 4faf9c8 [main] Upgrade to latest dependencies (# 8287)
  > 65aeab5 [main] Upgrade to latest dependencies (# 8275)
  > 03ba8f4 feat: autocreate v1beta3 eventtypes (# 8276)
bumping golang.org/x/net 6cc5ac4...334afa0:
  > 334afa0 go.mod: update golang.org/x dependencies
  > d7f220d quic: add LocalAddr and RemoteAddr to quic.Conn
  > 858db1a http2: surface errors occurring very early in a client conn's lifetime
  > 0aa844c http2: support unencrypted HTTP/2 handoff from net/http
  > f35fec9 http2: detect hung client connections by confirming stream resets
  > e883dae README: don't recommend go get
  > 511cc3a html: add Node.{Ancestors,ChildNodes,Descendants}()
  > 4783315 http2: limit 1xx based on size, do not limit when delivered
  > 5716b98 internal/socket: execute gofmt
  > 42b1186 http2: support ResponseController.EnableFullDuplex
bumping golang.org/x/term 9d5441a...b725e36:
  > b725e36 go.mod: update golang.org/x dependencies
  > 54df7da README: don't recommend go get

Signed-off-by: Knative Automation <[email protected]>
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
Copy link

knative-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@knative-prow knative-prow bot merged commit 72ccd4b into knative-extensions:main Nov 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants