rewrite flaky broker_deleted_recreated #8931
knative-style.yaml
on: pull_request
style
/
changes
2s
style
/
...
/
Auto-format and Check
18s
style
/
...
/
Lint
1m 50s
style
/
...
/
Do Not Submit
5s
style
/
...
/
shell
0s
style
/
...
/
yaml
0s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
6 errors and 4 warnings
style / Golang / Auto-format and Check:
test/rekt/features/broker_deleted_recreated.go#L1
Please run goimports.
diff --git a/test/rekt/features/broker_deleted_recreated.go b/test/rekt/features/broker_deleted_recreated.go
index 52fe1bc..a0f21c0 100644
--- a/test/rekt/features/broker_deleted_recreated.go
+++ b/test/rekt/features/broker_deleted_recreated.go
@@ -121,9 +121,9 @@ func BrokerDeletedRecreated() *feature.Feature {
// therefore, we check that eventually, the last few events sent (16 for no particular reason) are all received by the sink2 only
// and contain an uninterrupted (without any missing sequence numbers) source sequence as sent by the source with eventshub.AddSequence
EventSequenceOnStores(sink1, sink2).
- MatchingReceived(eventMatchers...). // ... when ...
- OrderedBySourceSequence(). // ..., and taken the ...
- LastN(16). // ... events, the sequence...
+ MatchingReceived(eventMatchers...). // ... when ...
+ OrderedBySourceSequence(). // ..., and taken the ...
+ LastN(16). // ... events, the sequence...
ContainsOnlyEventsObservedBy(sink2). // ...and...
IsAnUninterruptedSourceSequence().
Eventually(),
|
style / Golang / Auto-format and Check:
test/rekt/features/sequence_assertions.go#L1
Please run goimports.
diff --git a/test/rekt/features/sequence_assertions.go b/test/rekt/features/sequence_assertions.go
index 2abd279..40087bb 100644
--- a/test/rekt/features/sequence_assertions.go
+++ b/test/rekt/features/sequence_assertions.go
@@ -20,15 +20,17 @@ import (
"cmp"
"context"
"fmt"
+
"knative.dev/reconciler-test/pkg/eventshub/assert"
+ "slices"
+
cetest "github.com/cloudevents/sdk-go/v2/test"
types2 "github.com/cloudevents/sdk-go/v2/types"
"k8s.io/apimachinery/pkg/util/wait"
"knative.dev/reconciler-test/pkg/environment"
"knative.dev/reconciler-test/pkg/eventshub"
"knative.dev/reconciler-test/pkg/feature"
- "slices"
)
type sequenceTransformationOrAssertion func(ctx context.Context, events []eventshub.EventInfo) ([]eventshub.EventInfo, error)
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
style / Golang / Lint:
test/rekt/features/sequence_assertions.go#L205
SA1019: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
|
style / Golang / Lint:
test/rekt/features/broker_deleted_recreated.go#L27
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
|
style / Golang / Lint
issues found
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|