Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed links and modal behavior #961

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix: fixed links and modal behavior #961

merged 2 commits into from
Jun 23, 2023

Conversation

nhestrompia
Copy link
Contributor

@nhestrompia nhestrompia commented Jun 19, 2023 •
edited
Loading

fixed issues mentioned in #916, added links and modified behavior of modals. Now modals don't close when user changes tabs or window.

For onboarding link, waiting this #266

Base automatically changed from refactor(web)/migrate-to-wagmi to dev June 21, 2023 10:38
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 1277bec
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/649574fa44212e000878bf2a
😎 Deploy Preview https://deploy-preview-961--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 1277bec
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/649574fac8a5ed0008186f51
😎 Deploy Preview https://deploy-preview-961--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alcercu
alcercu approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 031a528 into dev Jun 23, 2023
@alcercu alcercu deleted the fix(web)/fix-links-and-modal-behavior branch June 23, 2023 10:51
@jaybuidl jaybuidl added this to the alpha-1 milestone Jun 23, 2023
@jaybuidl jaybuidl linked an issue Jun 23, 2023 that may be closed by this pull request
UI: Links to Help resources and Kleros Solutions #916
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Enhancement ✨
Projects
None yet
Milestone
testnet-1
Development

Successfully merging this pull request may close these issues.

UI: Links to Help resources and Kleros Solutions
3 participants
@nhestrompia @alcercu @jaybuidl