Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web)/case cards indicators #1463

Merged
merged 19 commits into from
Feb 2, 2024
Merged

Feat(web)/case cards indicators #1463

merged 19 commits into from
Feb 2, 2024

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented Jan 29, 2024 •
edited
Loading

⚠️ Requires subgraph re-deploy

  • Adds indicators on Dispute card that provide more insights to Jurors
  • Adds a rewardAmount entity to ClassicContribution
  • Fixes a bug in ensureClassicContributionFromEvent where it would increase amount even on Withdraw event, the amount in withdraw event is the reward/ reimburse amount , not the contributed amount

PR-Codex overview

The following files were skipped due to too many changes: web/src/assets/svgs/label-icons/evidence.svg, web/src/assets/svgs/label-icons/forgot-vote.svg, web/src/assets/svgs/label-icons/funded.svg, web/src/components/DisputeCard/CardLabels/Label.tsx, web/src/assets/svgs/label-icons/rewards-won.svg, web/src/assets/svgs/label-icons/appeal.svg, web/src/components/DisputeCard/CardLabels/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

❌ Deploy Preview for kleros-v2 failed.

Name Link
🔨 Latest commit 95073a0
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65bcbc4caa5e060008706e8b

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit 24f87d0 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 9
Duplication 4
Style 1

View more on Code Climate.

@Harman-singh-waraich Harman-singh-waraich linked an issue Jan 29, 2024 that may be closed by this pull request
Web: indicators and labels on the case cards #1443
Closed
@jaybuidl jaybuidl had a problem deploying to graph-studio-devnet January 31, 2024 10:54 — with GitHub Actions Failure
@alcercu alcercu had a problem deploying to graph-studio-devnet February 2, 2024 09:58 — with GitHub Actions Failure
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

alcercu
alcercu approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Feb 2, 2024
Merged via the queue into dev with commit e2a18cc Feb 2, 2024
8 of 14 checks passed
@alcercu alcercu deleted the feat(web)/case-cards-indicators branch February 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web: indicators and labels on the case cards
3 participants
@Harman-singh-waraich @alcercu @jaybuidl