Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(subgraph): incorrect totalVoted on ClassicRound #1400

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

alcercu
Copy link
Contributor

@alcercu alcercu commented Jan 10, 2024

PR-Codex overview

This PR focuses on updating the updateCountsAndGetCurrentRuling function in ClassicRound.ts.

Detailed summary

  • The choiceCount parameter has been renamed to delta.
  • The choiceCount variable has been replaced with newChoiceCount.
  • The logic for updating the newCounts array has been modified.
  • The conditions for updating the round.tied and round.winningChoice properties have been adjusted.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit d9a61c2
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65a9c52e64649900089d9bdc
😎 Deploy Preview https://deploy-preview-1400--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jan 10, 2024

Code Climate has analyzed commit ae6b663 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jaybuidl jaybuidl force-pushed the fix(subgraph)/incorrect-nbVoted branch from ae6b663 to d9a61c2 Compare January 19, 2024 00:41
@jaybuidl jaybuidl merged commit d9a61c2 into dev Jan 19, 2024
8 of 11 checks passed
@jaybuidl jaybuidl deleted the fix(subgraph)/incorrect-nbVoted branch January 19, 2024 00:41
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants